Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 352492

Summary: Toggle breakpoints target should have an enablement expression.
Product: z_Archived Reporter: Pawel Piech <pawel.1.piech>
Component: PDTAssignee: Zhongwei Zhao <zhaozhongwei>
Status: CLOSED FIXED QA Contact:
Severity: major    
Priority: P3 CC: kalin.a, mober.at+eclipse
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Patch with fix. pawel.1.piech: iplog+

Description Pawel Piech CLA 2011-07-19 13:24:37 EDT
Created attachment 199922 [details]
Patch with fix.

org.eclipse.php.internal.debug.ui.breakpoint.PHPToggleBreakpointsTargetFactory is registered without an enablement expression which causes the PHP plugins to be loaded prematurely.  Attached expression should be used.
Comment 1 Martin Oberhuber CLA 2011-07-20 08:30:51 EDT
CQ:WIND00288111

This is an important fix to make, because it not only triggers Platform misbehavior (bug 352502) but also performance penalty due to premature plugin loading.

Please consider attached patch for Indigo SR1, thanks!
Comment 2 Zhongwei Zhao CLA 2011-07-26 02:18:42 EDT
committed to head,thanks!
Comment 3 Martin Oberhuber CLA 2011-07-26 04:14:49 EDT
Thanks!

Is the HEAD stream what's going to lead up to Indigo SR1 ? Can we get builds from
https://hudson.eclipse.org/hudson/job/cbi-pdt-3.0-indigo/ ?
Comment 4 Zhongwei Zhao CLA 2011-07-26 04:38:51 EDT
hi,

https://hudson.eclipse.org/hudson/job/cbi-pdt-3.0-indigo/ is the nightly build from head version,and for Indigo SR1,I know nothing.
Comment 5 Kalin CLA 2011-08-01 10:03:40 EDT
Closing...
Comment 6 Pawel Piech CLA 2011-09-15 11:19:15 EDT
(In reply to comment #2)
> committed to head,thanks!

Thank You for the quick action.  I changed the flags to make autogenerated IP log right.