Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 352485

Summary: [Table] Default height of cells is too small, leading to text truncations
Product: z_Archived Reporter: Alain Le Guennec <alain.leguennec>
Component: EMF-FacetAssignee: Gregoire Dupe <gdupe>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P2 CC: eclipse-bugzilla, emft.facet-inbox, gdupe, nicolas.bros, yann.tanguy
Version: unspecifiedFlags: gdupe: indigo+
gdupe: juno+
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on:    
Bug Blocks: 422829    
Attachments:
Description Flags
Screenshot
gdupe: iplog-
A snapshot of the problem on Windows 7 gdupe: iplog-

Description Alain Le Guennec CLA 2011-07-19 12:07:11 EDT
Created attachment 199915 [details]
Screenshot

The default height of rows is too small.
The text in the cells is slightly truncated (the bottom of the text is not completely visible).
This is particularly annoying for the "header" row, as it cannot be resized.
See attached screenshot.
Comment 1 Vincent Lorenzo CLA 2011-07-26 04:34:32 EDT
(In reply to comment #0)
> Created attachment 199915 [details]
Hi Alain, 
   could you reproduce this bug, with EMF-Facet Nattable only (without using Papyrus) 
To try to reproduce this bug without Papyrus : 
	1/ open a UML file
	2/ right click on an element -> Edit in a table editor
	
Best regard, 
Vincent
Comment 2 Vincent Lorenzo CLA 2011-09-01 07:22:50 EDT
This problem seems exist when the OS is Windows 7. I can't reproduce the bug, on Windows XP and Linux Suse.
Comment 3 Vincent Lorenzo CLA 2011-09-01 07:26:01 EDT
Created attachment 202599 [details]
A snapshot of the problem on Windows 7
Comment 4 Nicolas Bros CLA 2011-09-01 08:02:44 EDT
I use Windows 7 and I have never experienced this truncation problem.
Maybe it's linked to another setting, like the font size preference in Windows?
Comment 5 Alain Le Guennec CLA 2011-09-01 08:19:10 EDT
I suspect this is due to the DPI setting for the screen.
I am using XP SP3, and could reproduce it with DPI set to 120,
but apparently the pb is no more present with DPI set to 96.
Comment 6 Vincent Lorenzo CLA 2011-09-02 04:15:21 EDT
Is it possible to do something to avoid this problem for the users?
Comment 7 Gregoire Dupe CLA 2011-09-08 04:05:37 EDT
This bug is not major (or upper), that why it cannot fixed for the SR1 (because we already are in the release candidate period).

Priority= P2
Comment 8 Vincent Lorenzo CLA 2011-10-03 08:23:48 EDT
P2 = Indigo SR2?
Comment 9 Gregoire Dupe CLA 2011-10-04 03:17:05 EDT
(In reply to comment #8)
> P2 = Indigo SR2?

Yes.
Comment 10 Gregoire Dupe CLA 2012-01-10 09:03:53 EST
I've modified the table implementation (in the SVN trunk) to use the system font to compute the default cell sizes.

Committed revision 1469.
Comment 11 Gregoire Dupe CLA 2012-01-10 09:30:48 EST
(In reply to comment #10)
> I've modified the table implementation (in the SVN trunk) to use the system
> font to compute the default cell sizes.
> 
> Committed revision 1469.

I've committed the same modification on the branch 0.1.

Committed revision 1469.
Comment 12 Gregoire Dupe CLA 2012-01-12 04:37:46 EST
Hello,

I’ve tested the table widget from the latest maintenance build (http://download.eclipse.org/facet/updates/nightly-maintenance/, 0.1.1.v201201111343). When I change my operating system font, the table still has a good rendering.

Alain and Vincent, please, can you test this version and tell me if this fix the problem on your computer?

Regards,
Grégoire
Comment 13 Gregoire Dupe CLA 2012-01-16 10:28:07 EST
To fix a problem with Windows 7, I've added a ratio depending of the DPI configuration.

Committed revision 1489.
Comment 14 Gregoire Dupe CLA 2012-01-16 10:39:25 EST
(In reply to comment #13)
> To fix a problem with Windows 7, I've added a ratio depending of the DPI
> configuration.

Committed on the trunk : Committed revision 1490.
Comment 15 Gregoire Dupe CLA 2012-05-23 06:38:39 EDT
Hello Alain,

Please, can you close this bug, if your problem has been solved ?

Regards,
Grégoire
Comment 16 Gregoire Dupe CLA 2013-05-28 08:44:21 EDT
This bug is closed since a long time: I assume it can be closed.