Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 352474

Summary: Compiler warnings in I20110719-0800
Product: [Eclipse Project] Equinox Reporter: Olivier Thomann <Olivier_Thomann>
Component: IncubatorAssignee: equinox.incubator-inbox <equinox.incubator-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: l.kirchev, tjwatson
Version: unspecified   
Target Milestone: Juno M1   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Olivier Thomann CLA 2011-07-19 11:16:50 EDT
From latest I-build page:

1. WARNING in /src/org/eclipse/equinox/console/commands/EquinoxCommandProvider.java
 (at line 296)
private static boolean matchCommand(String command, String input, int minLength) {
The method matchCommand(String, String, int) from the type EquinoxCommandProvider is never used locally
2. WARNING in /src/org/eclipse/equinox/console/commands/EquinoxCommandProvider.java
 (at line 1314)
ServiceReference envInfoRef = context.getServiceReference(EnvironmentInfo.class.getName());
ServiceReference is a raw type. References to generic type ServiceReference<S> should be parameterized
3. WARNING in /src/org/eclipse/equinox/console/commands/EquinoxCommandProvider.java
 (at line 1317)
EnvironmentInfo envInfo = context.getService(envInfoRef);
Type safety: Unchecked invocation getService(ServiceReference) of the generic method getService(ServiceReference<S>) of type BundleContext
4. WARNING in /src/org/eclipse/equinox/console/commands/EquinoxCommandProvider.java
 (at line 1317)
EnvironmentInfo envInfo = context.getService(envInfoRef);
Type safety: The expression of type ServiceReference needs unchecked conversion to conform to ServiceReference<EnvironmentInfo>

1. WARNING in /src/org/eclipse/equinox/console/commands/EquinoxCommandsConverter.java
 (at line 44)
List<String> args = (List<String>) in;
Type safety: Unchecked cast from Object to List<String>
2. WARNING in /src/org/eclipse/equinox/console/commands/EquinoxCommandsConverter.java
 (at line 119)
List<Dictionary<?, ?>> list = (List<Dictionary<?, ?>>) target;
Type safety: Unchecked cast from Object to List<Dictionary<?,?>>
Comment 1 Thomas Watson CLA 2011-07-19 13:04:24 EDT
Lazar, would you fix these warnings in the build?
Comment 2 Lazar Kirchev CLA 2011-07-20 01:52:13 EDT
(In reply to comment #1)
> Lazar, would you fix these warnings in the build?

Yes, sure.
Comment 3 Lazar Kirchev CLA 2011-07-20 08:39:09 EDT
I fixed the warnings and submitted the changes.
Comment 4 Thomas Watson CLA 2011-07-20 09:32:49 EDT
Thanks marking as fixed.