Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 352462

Summary:	[Compatibility] F1 does nothing in the 'Git Staging' view
Product:	[Eclipse Project] Platform	Reporter:	Remy Suen <remy.suen>
Component:	UI	Assignee:	Remy Suen <remy.suen>
Status:	VERIFIED FIXED	QA Contact:	Remy Suen <remy.suen>
Severity:	major
Priority:	P3	CC:	daniel_megert
Version:	4.1
Target Milestone:	4.1.1
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:
Bug Blocks:	331240

Description Remy Suen

2011-07-19 10:15:10 EDT

Pressing F1 seems to do nothing in the 'Git Staging' view.

Strictly speaking, the content isn't of interest it just says the following in 3.x (which seems to be completely useless):

About Git Staging
Each workbench window contains one or more perspectives, which are made up of various views and editors.

Comment 1 Remy Suen

2011-07-19 10:33:17 EDT

(In reply to comment #0)
> About Git Staging
> Each workbench window contains one or more perspectives, which are made up of
> various views and editors.

Unsurprisingly, on 3.x it is the shell that is getting the help event. This would explain why we're getting information about the workbench window.

Comment 2 Remy Suen

2011-07-19 13:18:44 EDT

We had no contextual help setup for the workbench window's shell so we were not presenting any information when the help event recursed up to the shell.

Fix released to R4_development in 5eec2b04a70f704a7cdc1b77db59bb90ec03dd68.
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_development&id=5eec2b04a70f704a7cdc1b77db59bb90ec03dd68

Comment 3 Dani Megert

2011-07-20 04:00:43 EDT

Did you file a bug against EGit to actually provide some useful help?

Comment 4 Remy Suen

2011-07-20 06:13:21 EDT

(In reply to comment #3)
> Did you file a bug against EGit to actually provide some useful help?

That I haven't. I think the philosophy there is to rely on the wiki for everything.

Comment 5 Dani Megert

2011-07-20 06:16:02 EDT

(In reply to comment #4)
> (In reply to comment #3)
> > Did you file a bug against EGit to actually provide some useful help?
> 
> That I haven't. I think the philosophy there is to rely on the wiki for
> everything.

Then there F1 help should say that including a link to the wiki - preferably to the section that describes the corresponding UI element.

Comment 6 Remy Suen

2011-08-26 09:35:52 EDT

Verified with M20110817-2001 on Windows XP.