Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 352440

Summary: Remove deprecation warnings
Product: [Modeling] Graphiti Reporter: Michael Wenz <michael.wenz>
Component: CoreAssignee: Michael Wenz <michael.wenz>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 Flags: michael.wenz: juno+
Version: 0.8.0   
Target Milestone: 0.9.0   
Hardware: All   
OS: All   
Whiteboard: Juno M4 Theme_round_offs
Attachments:
Description Flags
Proposed patch michael.wenz: iplog+

Description Michael Wenz CLA 2011-07-19 07:24:01 EDT 
Remove the deprecation warnings in Graphiti coding, especially those for GEF. Keep the upcoming version of Graphiti compilable and runnable against Eclipse 3.7 and especially GEF 3.7.
Comment 1 Michael Wenz CLA 2011-07-19 07:24:32 EDT 
Targeted for Juno
Comment 2 Felix Velasco CLA 2011-11-08 09:49:58 EST 
Created attachment 206599 [details]
Proposed patch

Proposed solution, please review.
I'm not really sure about the GFCommandStack modification, since in order to remove the deprecation we need to replicate the listeners management. Maybe it's a bit overkill.
Comment 3 Michael Wenz CLA 2011-11-08 10:49:59 EST 
(In reply to comment #2)
> Created attachment 206599 [details]
> Proposed patch
> Proposed solution, please review.
> I'm not really sure about the GFCommandStack modification, since in order to
> remove the deprecation we need to replicate the listeners management. Maybe
> it's a bit overkill.
Great! Thanks for the patch! We will have a closer look after M3.
Comment 4 Michael Wenz CLA 2011-11-09 07:20:13 EST 
I applied the patch to our head version and submitted the changes to Eclipse. I only took out the GFCommandStack modifications as the replication would probably not really improve things. Committed with
commit 627fe402671239646ddccd336e4dbf603614d7cf
Author: mwenz <michael.wenz@sap.com> 2011-11-09 13:17:03
Committer: mwenz <michael.wenz@sap.com> 2011-11-09 13:17:03
Parent: 6407709aaf2e0f61e60540f41672c1353e2545d9 (Updated New&Noteworthy for M3)
Branches: origin/master, master
Comment 5 Michael Wenz CLA 2011-11-09 08:25:08 EST 
I fixed some more warnings with
commit 913ce8cddf8d0a71c593e9c26d0745bc12484245
Author: mwenz <michael.wenz@sap.com> 2011-11-09 14:12:28
Committer: mwenz <michael.wenz@sap.com> 2011-11-09 14:12:28
Parent: 627fe402671239646ddccd336e4dbf603614d7cf (Bug 352440: Applied patch to fix deprecation warnings, but keep GFCommandStack unchanged)
Branches: origin/master, master
Comment 6 Michael Wenz CLA 2011-11-11 04:45:22 EST 
The warnings have disappeared also in the central build log
Comment 7 Michael Wenz CLA 2012-04-11 10:46:50 EDT 
Bookkeeping: Set target release
Comment 8 Michael Wenz CLA 2012-06-29 04:14:43 EDT 
Part of Graphiti 0.9.0 (Eclipse Juno)