Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 352382

Summary: RepositoriesViewCommandHandler should use the HandlerUtil to retrieve variables
Product: [Technology] EGit Reporter: Remy Suen <remy.suen>
Component: UIAssignee: Project Inbox <egit.ui-inbox>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: dariusz.luksza, pwebster
Version: 1.1   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 331240    

Description Remy Suen CLA 2011-07-18 14:42:29 EDT 
In enableWhenRepositoryHaveHead(Object), an instanceof check is performed on the context as to whether or not it is an EvaluationContext or not. This assumption may not necessarily be valid so HandlerUtil's getVariable(Object, String) method should be used instead for retrieving variables out of an evaluation context.
Comment 1 Remy Suen CLA 2011-07-18 15:10:52 EDT 
A proposed change set has been pushed to Gerrit for review.
http://egit.eclipse.org/r/#change,3894
Comment 2 Dariusz Luksza CLA 2011-07-18 17:05:51 EDT 
merged as 86f6e33d63c668a0f8a6c3938b14884daf4fc2c5
Comment 3 Remy Suen CLA 2011-07-19 08:22:14 EDT 
Verified with EGit 1.1.0.201107181713 on Windows XP.