Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 352379

Summary:

[LTTng] Statistics view - reset/update not performed when fast change of trace

Product:

z_Archived

Reporter:

Mathieu Denis <mathieu.denis>

Component:

LinuxTools

Assignee:

Bernd Hufmann <bernd.hufmann>

Status:

CLOSED FIXED

QA Contact:

Francois Chouinard <fchouinard>

Severity:

normal

Priority:

CC:

bernd.hufmann, jjohnstn

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
Temporary fix to handle failed requests	none
Dispose correctly of the loading experiment when another one is selected	bernd.hufmann: iplog+
Fix for bug	bernd.hufmann: iplog-
Fix for bug (stable-0.8)	jjohnstn: iplog+

Description Mathieu Denis

2011-07-18 14:30:11 EDT

Build Identifier: 20110526-1053

If a trace is big enough, selecting another trace/experiment while the big one is loading will result in wrong statistics for the big trace that has been interrupted. The trace does not need to be that big. If done fast, it will result in the same misinformation.

The plug-in remember that the trace was already loaded before, so it doesn't reload it, but it was not completed in the first place.

Reproducible: Always

Steps to Reproduce:
1. Open a big trace (1)
2. While the trace you have selected is being loaded in background, select different trace (2).
3. Get back to the big trace (1)
4. The statistics will not show the real event number of the trace (1). There will be missing events, those that were not yet loaded when you clicked on the trace (2).

Comment 1 Mathieu Denis

2011-08-01 17:23:31 EDT

The eventHeap is getting flushed before the first experiment has been disposed. Therefore, there is a NullPointerException raised.

Comment 2 Mathieu Denis

2011-08-02 11:26:21 EDT

Created attachment 200730 [details]
Temporary fix to handle failed requests

Temporary fix to handle failed requests while we fix the experiment concurrency issue.

Comment 3 mathieu.denis

2011-08-25 15:41:32 EDT

Created attachment 202174 [details]
Dispose correctly of the loading experiment when another one is selected

Patch generated from git in command line.

Comment 4 Bernd Hufmann

2011-08-29 11:04:44 EDT

(In reply to comment #3)
Thanks Mathieu for the patch. I'm going to include the fix.
/Bernd

Comment 5 Bernd Hufmann

2011-08-29 11:14:30 EDT

Created attachment 202334 [details]
Fix for bug

Fix for bug. It augments attachment 202174 [details].

Comment 6 Bernd Hufmann

2011-08-29 14:27:26 EDT

(In reply to comment #5)
Patch is based on master.

Comment 7 Bernd Hufmann

2011-08-29 14:28:22 EDT

Created attachment 202350 [details]
Fix for bug (stable-0.8)

Fix for bug based on branch stable-0.8.

Comment 8 Bernd Hufmann

2011-08-29 14:29:13 EDT

Patches commited!

Comment 9 Francois Chouinard

2011-09-28 17:39:17 EDT

Delivered with 0.8.1