Bugzilla – Full Text Bug Listing
| Summary: | XtextRunner overrides global registries | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Modeling] TMF | Reporter: | Sebastian Benz <sebastian.benz> | ||||||||
| Component: | Xtext | Assignee: | Project Inbox <tmf.xtext-inbox> | ||||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | sebastian.zarnekow | ||||||||
| Version: | 2.0.1 | Flags: | sebastian.zarnekow:
indigo+
|
||||||||
| Target Milestone: | SR1 | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
We should make sure that the InjectProvider actually implements the interface IRegistryConfigurator before we cast it, shouldn't we? Created attachment 199873 [details]
Updated bug fix & test
Ouh. Of course we should. I updated the patch. (In reply to comment #1) > We should make sure that the InjectProvider actually implements the interface > IRegistryConfigurator before we cast it, shouldn't we? Created attachment 199874 [details]
Accidentally uploaded the wrong version of the patch.
Thanks for the patch. I moved the XtextRunnerTest to a new plugin org.eclipse.xtext.junit4.tests Closing all bugs that were set to RESOLVED before Neon.0 Closing all bugs that were set to RESOLVED before Neon.0 |
Created attachment 199841 [details] Fix and test case. The XtextRunner creates the injector before saving the global registries. Unfortunately, the generated standalone injector providers also initialize the registries when creating the injector. This leads to the global registries being overridden before they are saved. I attached a patch with a fix and a test.