Bugzilla – Full Text Bug Listing
| Summary: | ExitConfirmation containing quotation marks causes javascript error | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [RT] RAP | Reporter: | Michael Klein <michael.klein> | ||||
| Component: | RWT | Assignee: | Project Inbox <rap-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | tbuschto | ||||
| Version: | 1.4 | ||||||
| Target Milestone: | 1.5 M1 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | sr141 | ||||||
| Attachments: |
|
||||||
Created attachment 199816 [details]
Proposed patch for v1.4_Maintenance
Fixed in CVS HEAD by escaping double quotes in DisplayLCA#writeExitConfirmation. (In reply to comment #1) The proposed patch works for me. Thanks for the quick fix. Applied patch to 1.4_Maintenance. Commited patch to v14_Tree_Table_Merge branch |
Environment: Firefox 5.0/IE 9.0.8112 on Win7 The bug occurs using RAP 1.4 (maintenance branch) and HEAD Steps to reproduce: * create a plugin * define an extension for the org.eclipse.rap.ui.branding extension point * create an exit confirmation * let the method getExitConfirmationText() return a string containing quotation marks * start the RAP application -> Javascript error occurred Here is an exit confirmation to reproduce: public class MyExitConfirmation implements IExitConfirmation { public String getExitConfirmationText() { return "Hello \"World\""; } public boolean showExitConfirmation() { return true; } }