Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 352193

Summary: SWT.CHECK and SWT.MULTI Table space checks only first selected item
Product: [Eclipse Project] Platform Reporter: Philippe Marschall <philippe.marschall>
Component: SWTAssignee: Lakshmi P Shanmugam <lshanmug>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: archangel179, eclipse.felipe, lshanmug, michael.pellaton, niraj.modi, sravankumarl
Version: 3.7   
Target Milestone: 4.15 M3   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/155070
https://git.eclipse.org/r/155597
https://bugs.eclipse.org/bugs/show_bug.cgi?id=559771
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=ee314c11282db5262166d5aaf3a7b7cbc4b27f2b
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=6405c599446cbf8c81b470d7b9642bfc3da223a6
Whiteboard:
Attachments:
Description Flags
a simple table with SWT.MULTI and SWT.CHECK
none
patch for win32
none
patch for cocoa none

Description Philippe Marschall CLA 2011-07-15 06:14:07 EDT
Build Identifier: I20110613-1736

When in a table with SWT.CHECK and SWT.MULTI multiple items are selected and space is pressed only the last selected item is checked.

Reproducible: Always

Steps to Reproduce:
1. create a table SWT.CHECK and SWT.MULTI
2. select multiple items
3. hit space
Comment 1 Philippe Marschall CLA 2011-07-15 06:15:55 EDT
Created attachment 199735 [details]
a simple table with SWT.MULTI and SWT.CHECK
Comment 2 Philippe Marschall CLA 2011-07-18 04:12:14 EDT
Created attachment 199810 [details]
patch for win32
Comment 3 Felipe Heidrich CLA 2011-07-18 10:59:08 EDT
(In reply to comment #2)
> Created attachment 199810 [details]
> patch for win32

What happens on Linux-GTK and Mac-Cocoa ?
Comment 4 Philippe Marschall CLA 2011-07-18 11:34:32 EDT
GTK+ has the same behavior as Win32 so it needs a patch as well. I haven't tested Cocoa yet.
Comment 5 Felipe Heidrich CLA 2011-07-18 12:36:15 EDT
Okay, I tested Table and Tree on Windows/GTK/Mac

This behaviour is consistent on all platforms.
Pressing the spacebar only checks one item.
Comment 6 Philippe Marschall CLA 2011-07-18 14:15:39 EDT
Created attachment 199854 [details]
patch for cocoa
Comment 7 Philippe Marschall CLA 2011-08-08 04:44:03 EDT
I checked the native behavior in the Windows Update dialog (where you can select all the updates you want to install). Pressing space checks all the selected items, not just the one with focus.
Comment 8 Lars Vogel CLA 2019-11-14 03:48:31 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.
Comment 9 Philippe Marschall CLA 2019-11-14 06:32:13 EST
The bug is still present with SWT 3.11, I'm still interested in seeing this fixed.
Comment 10 Lakshmi P Shanmugam CLA 2019-11-14 23:53:35 EST
(In reply to Philippe Marschall from comment #9)
> The bug is still present with SWT 3.11, I'm still interested in seeing this
> fixed.

@Phillippe,
It'll be very helpful if you can update the patches and provide them via gerrit.
Please see: https://www.eclipse.org/swt/fixbugs.php.
Comment 11 Lakshmi P Shanmugam CLA 2019-12-16 05:20:16 EST
(In reply to Lakshmi Shanmugam from comment #10)
> (In reply to Philippe Marschall from comment #9)
> > The bug is still present with SWT 3.11, I'm still interested in seeing this
> > fixed.
> 
> @Phillippe,
> It'll be very helpful if you can update the patches and provide them via
> gerrit.
> Please see: https://www.eclipse.org/swt/fixbugs.php.

Do you plan to provide the patches via gerrit? If not, I'll try to move them next week. This is has to be fixed on GTK too for consistent behavior.
Comment 12 Philippe Marschall CLA 2019-12-16 05:22:39 EST
(In reply to Lakshmi Shanmugam from comment #11)
> ...
> 
> Do you plan to provide the patches via gerrit? If not, I'll try to move them
> next week. This is has to be fixed on GTK too for consistent behavior.

I don't think I'll have time in the foreseeable future.
Comment 13 Eclipse Genie CLA 2019-12-27 07:15:55 EST
New Gerrit change created: https://git.eclipse.org/r/155070
Comment 14 Lakshmi P Shanmugam CLA 2020-01-06 03:25:25 EST
@Niraj,
Can u please try the windows patch from comment#2?
Comment 15 Eclipse Genie CLA 2020-01-10 04:33:33 EST
New Gerrit change created: https://git.eclipse.org/r/155597
Comment 16 Lakshmi P Shanmugam CLA 2020-01-10 07:18:39 EST
(In reply to Eclipse Genie from comment #15)
> New Gerrit change created: https://git.eclipse.org/r/155597

Thanks Niraj. We need to fix GTK too before we can merge the changes.
Comment 17 Lakshmi P Shanmugam CLA 2020-02-03 01:33:08 EST
(In reply to Lakshmi Shanmugam from comment #16)
> (In reply to Eclipse Genie from comment #15)
> > New Gerrit change created: https://git.eclipse.org/r/155597
> 
> Thanks Niraj. We need to fix GTK too before we can merge the changes.

Opened 559771 to track the fix on GTK.
Comment 20 Paul Pazderski CLA 2020-02-07 09:35:15 EST
*** Bug 403424 has been marked as a duplicate of this bug. ***
Comment 21 Sravan Kumar Lakkimsetti CLA 2020-02-17 03:24:47 EST
Not fixed on GTK and this tracked via bug 559771
Comment 22 Lakshmi P Shanmugam CLA 2020-02-18 03:10:43 EST
Verified on macOS 10.15 with I20200217-1800