Bug 352083

Description Dominik G. 2011-07-14 09:20:21 EDT

Build: RAP 1.4 (with integrated fix for https://bugs.eclipse.org/bugs/show_bug.cgi?id=349671),
       RAP Nightly Build (rap-runtime-1.5.0-N-20110713-2127.zip)

Bug 1:
If I use multiple browser widgets at the same time the completed() event is not received by all browser widgets (see screenshot: bug_load.jpg).

While I have created this snippet to reproduce this behaviour I detected another strange behaviour.

Bug 2:
If I call browser.setUrl("") to clear all the browser widgets, some of them receive a completed() event.
I think this event should be fired for all browser widgets or none (see screenshot: bug_reset.jpg). 

  
Here is the snippet to reproduce:


public class ProgressListenerCompletedBug2 implements IEntryPoint {

	public int createUI() {
		Display display = new Display();
		Shell shell = new Shell(display, SWT.NO_TRIM);
		shell.setMaximized(true);
		createContent(shell);
		shell.layout();
		shell.open();

		while (!shell.isDisposed()) {
			if (!display.readAndDispatch()) {
				display.sleep();
			}
		}
		return 0;
	}

	private void createContent(Shell shell) {
		shell.setLayout(new GridLayout(4, false));

		Button buttonReset = new Button(shell, SWT.PUSH);
		buttonReset.setLayoutData(new GridData(SWT.CENTER, SWT.CENTER, true, false, 4, 1));
		buttonReset.setText("Reset");

		Button buttonLoad = new Button(shell, SWT.PUSH);
		buttonLoad.setLayoutData(new GridData(SWT.CENTER, SWT.CENTER, true, false, 4, 1));
		buttonLoad.setText("Load");

		String url = "http://www.eclipse.org";
		int count = 26;
		final List<ResultHelper> browserList = new ArrayList<ResultHelper>();
		for (int i = 0; i < count; i++) {
			browserList.add(createBrowserArea(shell, url));
		}

		buttonReset.addSelectionListener(new SelectionAdapter() {

			@Override
			public void widgetSelected(SelectionEvent e) {
				for (ResultHelper helper : browserList) {
					showEmptyMessage(helper.text);
					helper.browser.setUrl("");
				}
			}

		});
		buttonLoad.addSelectionListener(new SelectionAdapter() {

			@Override
			public void widgetSelected(SelectionEvent e) {
				for (final ResultHelper helper : browserList) {
					showEmptyMessage(helper.text);
					helper.browser.setUrl(helper.url);
					showLoadingMessage(helper.text);
				}
			}

		});
	}

	private ResultHelper createBrowserArea(Composite parent, String url) {
		final Browser browser = new Browser(parent, SWT.BORDER);
		browser.setLayoutData(new GridData(SWT.FILL, SWT.FILL, true, true));

		final Text text = new Text(parent, SWT.SINGLE | SWT.CENTER | SWT.BORDER);
		text.setLayoutData(GridDataFactory.swtDefaults()
				.align(SWT.FILL, SWT.FILL).hint(200, 15).create());
		showEmptyMessage(text);

		browser.addProgressListener(new ProgressListener() {

			public void completed(ProgressEvent event) {
				showCompletedMessage(text);
			}

			public void changed(ProgressEvent event) {
				// nothing
			}

		});

		return new ResultHelper(browser, text, url);
	}

	private void showEmptyMessage(Text text) {
		text.setBackground(text.getDisplay().getSystemColor(SWT.COLOR_WHITE));
		text.setText("");
	}

	private void showLoadingMessage(Text text) {
		text.setBackground(text.getDisplay().getSystemColor(SWT.COLOR_YELLOW));
		text.setText("Loading URL ...");
	}

	private void showCompletedMessage(Text text) {
		text.setBackground(text.getDisplay().getSystemColor(SWT.COLOR_GREEN));
		text.setText("Completed event detected!");
	}

	private static class ResultHelper {

		Browser browser;
		Text text;
		String url;

		public ResultHelper(Browser browser, Text text, String url) {
			super();
			this.browser = browser;
			this.text = text;
			this.url = url;
		}

	}

}


Results:
- Most of the time the completed() event is called on every browser widget for each "load" action. From time to time some browser widgets were not informed.
- On the "reset" action, some widgets receive a completed() event while the majority doesn't.  

Expected Result:
- ProgressListener.completed() will always be called if the page was loaded.
- If we reset the browser URL the behaviour should be the same for all widgets. 


Please add a fix also for the comming RAP 1.4SR1.
(Prerequisite: bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=349671 will also be added for RAP 1.4SR1).