Bugzilla – Full Text Bug Listing
| Summary: | RSE attempts to use proxy where it should not | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] Target Management | Reporter: | Eugene Melekhov <melekhov> | ||||||
| Component: | RSE | Assignee: | Anna Dushistova <anna.dushistova> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | Martin Oberhuber <mober.at+eclipse> | ||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | anna.dushistova, ymnk | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | 3.4 M7 | ||||||||
| Hardware: | PC | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Eugene Melekhov
This sounds like bug 221843, which was resolved as a duplicate of bug 238796 . I think that the "Proxy bypass" list on the Preferences : General : Network page should work to exclude hosts. I'm not sure whether it can also exclude networks (I think it should, so that might be a valid enhancement request against Platform e.g. using netmask notation like "128.224.199.0/ffffff00" or "128.224.199.0/24). Beyond that, protocol-specific proxy lists have often been discussed but AFAIK never been implemented; AFAIK a SOCKS proxy is meant to be able and translate ANY socket connection protocol including SSH. So in my understanding, as of today Eclipse Proxy UI is meant to be used for all protocols (which is at least consistent, ant may be expected in many cases). See also bug 221332 comment 1 for some background. Maybe somebody (org.eclipse.core.net ?) would need to register a special proxy provider for SSH and give it priority over SOCKS I tested it and the bypass option now works for hosts, haven't tested networks yet. Martin, do you think it would be possible to at least have an option in the new connection wizard to inherit/bypass the proxies? I agree about SOCKS, but jcraft also uses HTTPS settings. I think it's incorrect. This is an interesting idea. Since we know that jsch uses a configured proxy by default (for SOCKS at least), the new connection wizard could have an option Direct connection (bypass proxies) When it's enabled, the target IP is automatically added to the proxy exclusion list. I guess my only concern is about lifecycle of such automatic settings. What if the target IP is changed / deleted ... the proxy exclusion would remain. It may be better to just add a button to the new connection wizard, which brings up the proxy configuration preference page (maybe with the new IP prefilled). Then users know what gets configured and where, rather than doing magic under the hood. I dont quite understand your comment about HTTPS. Created attachment 209133 [details]
a link to the preferences in the wizard page
Martin,
How about something like this?
Never mind, I read the links you mentioned before and I now take this back. (In reply to comment #4) > I dont quite understand your comment about HTTPS. I certainly have no objections to this approach (provided that you can code it with OK dependencies). Is this kind of integration sufficient for you in terms of usability ? I.e. will users know when they need to navigate into the Proxy Preferences ? Created attachment 210019 [details]
Patch that implements the proposed UI
Here is how I want to do it. Martin, do you think it's okay to check this in?
Also, which properties file should I use to externalize my string? I checked in the proposed patch. I don't think there is much else we can do here, so I am resolving it as fixed. |