Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 352070

Summary: JavaScript Error after pressing page up/down in active combo box cell editor
Product: [RT] RAP Reporter: Sabine Neubauer <neubauer>
Component: RWTAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P2 CC: tbuschto
Version: 1.4   
Target Milestone: 1.5 M1   
Hardware: All   
OS: All   
Whiteboard: sr141
Attachments:
Description Flags
Test project for reproducing
none
Proposed patch for v14_Maintenance branch
none
Proposed patch for v14_Maintenance branch ivan: review?

Description Sabine Neubauer CLA 2011-07-14 07:52:22 EDT 
Build Identifier: 

If a user presses the key PageUp or PageDown in a active combo box cell editor (where the list is not displayed), the following java script error occurs.
------------------------
Javascript error occurred:

qx.ui.layout.VerticalBoxLayout: Element must be created previously!
-------------------------

I will attach a test project for reproducing the problem. 

Further information:
- RAP 1.4
- tested browsers: Firefox 3.6 and InternetExplorer 8


Reproducible: Always

Steps to Reproduce:
1. Run TestProject.launch
2. Activate cell editor by clicking one time on  a cell -> cursor is in the cell
3. Press pageUp or pageDown
=> Java script error page
Comment 1 Sabine Neubauer CLA 2011-07-14 07:54:04 EDT 
Created attachment 199653 [details]
Test project for reproducing

Test project containing a view with table viewer having ComboBoxCellEditors based on the following jface snippet: http://dev.eclipse.org/viewcvs/viewvc.cgi/org.eclipse.jface.snippets/Eclipse%20JFace%20Snippets/org/eclipse/jface/snippets/viewers/Snippet027ComboBoxCellEditors.java?view=markup
Comment 2 Ivan Furnadjiev CLA 2011-07-14 08:20:50 EDT 
Reproducible with Controls Demo -> Combo Tab too.
Comment 3 Ivan Furnadjiev CLA 2011-07-14 09:46:30 EDT 
It seems that this is a very old bug. Just checked with 1.3 release and it is there, but the error is only shown in browser javascript error console. With the fix for bug 334758 these hidden javascript errors now surfaced.
Comment 4 Ivan Furnadjiev CLA 2011-07-14 10:34:08 EDT 
The actual error is in qx.ui.selection.SelectionManager.js#getPageUp/getPageDown when calling getScrollTop/getClientHeight on non created widget.
Comment 5 Ivan Furnadjiev CLA 2011-07-20 08:04:37 EDT 
Fixed in CVS HEAD in qx.ui.selection.SelectionManager.js#getPageUp/getPageDown by checking if vBoundedWidget is created before start the calculation. JS test added.
Comment 6 Ivan Furnadjiev CLA 2011-07-20 08:06:03 EDT 
Created attachment 199980 [details]
Proposed patch for v14_Maintenance branch

Same fix as the one committed in CVS HEAD.
Comment 7 Sabine Neubauer CLA 2011-07-21 04:07:24 EDT 
I adapt the patch (fragment q07) and apply it to our used RAP plugins based on RAP 1.4 Maintenance branch. The error does not occur anymore. Thanks for the patch.
Comment 8 Ivan Furnadjiev CLA 2011-07-21 04:17:22 EDT 
Created attachment 200059 [details]
Proposed patch for v14_Maintenance branch

(In reply to comment #7)
> I adapt the patch (fragment q07) ...
Sorry for the trouble... my fault (the patch was against HEAD). This is the same patch against v14_Maintenance branch - no need to adapt it anymore.
Comment 9 Ivan Furnadjiev CLA 2011-07-26 04:08:59 EDT 
Applied patch to v14_Maintenance branch.
Comment 10 Tim Buschtoens CLA 2011-08-25 08:50:55 EDT 
Commited patch to v14_Tree_Table_Merge branch.