Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 351962

Summary: [performance] Revert unnecessary changes to MethodScope#createMethod
Product: [WebTools] JSDT Reporter: Ian Tewksbury <itewksbu>
Component: GeneralAssignee: Ian Tewksbury <itewksbu>
Status: RESOLVED FIXED QA Contact: Nitin Dahyabhai <thatnitind>
Severity: normal    
Priority: P3 CC: cmjaun
Version: 3.2.5Keywords: performance
Target Milestone: 3.2.5Flags: cmjaun: review+
thatnitind: review+
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Fix Patch
none
Updated patch none

Description Ian Tewksbury CLA 2011-07-13 08:42:35 EDT 
Bug 306958 made unnecessary changes to MethodScope#createMethod.  These changes were not only not necessary but also cause a performance regression.  These changes should be backed out.
Comment 1 Ian Tewksbury CLA 2011-07-13 08:44:47 EDT 
Created attachment 199574 [details]
Fix Patch

Backs out the changes to MethodScope#createMethod done by bug 306958.

All existing JUnits still pass even after reverting these changes.  Including all of the new content assist tests provided in bug 306958.
Comment 2 Chris Jaun CLA 2011-07-13 11:51:22 EDT 
Created attachment 199604 [details]
Updated patch

The previous patch was not sufficient to solve the performance problem.
Comment 3 Nitin Dahyabhai CLA 2011-07-13 16:17:10 EDT 
Applied to R3_2_maintenance.
Comment 4 Nitin Dahyabhai CLA 2011-07-14 01:44:48 EDT 
Done