Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 351883

Summary: StandardCredentialsProvider.getCredentials() ignores password cache
Product: [Tools] Target Management Reporter: David McKnight <dmcknigh>
Component: RSEAssignee: David McKnight <dmcknigh>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: normal    
Priority: P3 CC: ddykstal.eclipse
Version: 3.2Flags: ddykstal.eclipse: review+
Target Milestone: 3.3.1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch to check password store none

Description David McKnight CLA 2011-07-12 14:38:00 EDT
When a user disconnects from an RSE connection, the in-memory password for the StandardCredentialsProvider is cleared.  If the user then tries to reconnect directly via IConnectorService.connect(IProgressMonitor monitor) the connect will fail because there is no password and StandardCredentialsProvider.getCredentials() doesn't look at the password cache.  If there is null password and user chose to save the password prior then we should pick up the password from the cache.
Comment 1 David McKnight CLA 2011-07-12 14:39:49 EDT
Created attachment 199524 [details]
patch to check password store
Comment 2 David McKnight CLA 2011-07-12 14:40:58 EDT
Dave, could you please review this patch?
Comment 3 David McKnight CLA 2011-07-12 15:18:52 EDT
Thanks for the review, Dave.  I've committed the change to cvs.
Comment 4 Martin Oberhuber CLA 2011-07-18 11:34:25 EDT
Released > I20110718, tagged as R33x_v201107181530