Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 351868

Summary: Upgrade embedded Spring framework to 3.2.10.RELEASE or later
Product: [RT] Virgo Reporter: Glyn Normington <glyn.normington>
Component: runtimeAssignee: Florian Waibel <fwaibel>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: flavio.donze, fwaibel, milesg78
Version: 3.0.0.M06   
Target Milestone: 3.7.0.M02   
Hardware: All   
OS: All   
URL: http://wiki.eclipse.org/Virgo/FAQ#How_can_I_change_the_version_of_Spring_framework_in_the_user_region.3F
Whiteboard:
Bug Depends on: 357273    
Bug Blocks:    

Description Glyn Normington CLA 2011-07-12 11:43:18 EDT
Virgo 3.0 specifies the range [2.5.6,3.1.0) and so any version of Spring framework can be used from 2.5.6 inclusive up to and including 3.0.x, but version 3.1.0 and later cannot.
Comment 1 Glyn Normington CLA 2011-10-19 10:38:17 EDT
Note that Spring framework 3.1RC1 requires additional dependencies to be present in Virgo. I have raised a Spring bug to get this changed: https://jira.springsource.org/browse/SPR-8788.
Comment 2 Glyn Normington CLA 2011-10-19 10:41:29 EDT
(In reply to comment #0)
> Virgo 3.0 specifies the range [2.5.6,3.1.0) and so any version of Spring
> framework can be used from 2.5.6 inclusive up to and including 3.0.x, but
> version 3.1.0 and later cannot.

Note that the fix to bug 357273 widened the version ranges appropriately.

So this bug may be implemented by upgrading Virgo's Spring framework dependencies after getting the necessary CQs approved.
Comment 3 Violeta Georgieva CLA 2014-07-23 16:44:04 EDT
CQs for Spring 3.2.10 are created
CQ8473 org.springframework.aop
CQ8474 org.springframework.aspects 
CQ8475 org.springframework.beans 
CQ8476 org.springframework.context 
CQ8477 org.springframework.context.support 
CQ8479 org.springframework.core 
CQ8480 org.springframework.expression 
CQ8481 org.springframework.jdbc 
CQ8482 org.springframework.jms
CQ8483 org.springframework.orm
CQ8484 org.springframework.oxm
CQ8485 org.springframework.transaction 
CQ8489 org.springframework.web
CQ8490 org.springframework.web.portlet 
CQ8491 org.springframework.web.servlet
Comment 4 Florian Waibel CLA 2014-07-25 07:12:21 EDT
I updated Glyn's testspringbundleresolution and was able to verify that the 3.2.4.RELEASE artefacts are deployable without introducing new dependencies.

The updated tool is available here: https://github.com/fwaibel/testspringbundleresolution
Comment 5 Florian Waibel CLA 2015-05-12 09:11:11 EDT
After upgrading there is one test failure:

Regression

org.eclipse.virgo.web.dm.ServerOsgiBundleXmlWebApplicationContextTests.retrievalOfBundleContextFromApplicationContext
Failing for the past 1 build (Since Unstable#107 )
Took 0.15 sec.
add description
Error Message

java.lang.AssertionError: 
  Unexpected method call getEnvironment():
    getBundleContext(): expected: 1, actual: 0
Comment 6 Florian Waibel CLA 2015-05-16 03:37:36 EDT
Reviewed the changes in Spring Framework and fixed the test.
Comment 7 Florian Waibel CLA 2016-04-11 10:20:37 EDT
3.7.0.M02 has been shipped with Spring 4.2.1.RELEASE.