Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 351814

Summary:

FocusCellOwnerDrawHighlighter does not clear multi selection coloring properly

Product:

[RT] RAP

Reporter:

Ivan Furnadjiev <ivan>

Component:

JFace

Assignee:

Project Inbox <rap-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

1.3

Target Milestone:

1.5 M1

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Proposed patch for v14_Maintenance branch	none

Description Ivan Furnadjiev

2011-07-12 06:48:17 EDT

Steps to reproduce:
1. Start Controls Demo -> TableViewer Tab
2. Check MULTI checkbox
3. Create Cell Editor
4. Make a multi selection - select with CTRL "Karl", "Sofia" and "Donald" for example
5. Click on "Nero" to select a single item
6. Only the selection coloring from the last (focused) cell is removed. "Karl" and "Sofia" still have the selection background color.
This is a regression introduced with the bugfix for bug 284738.

Comment 1 Ivan Furnadjiev

2011-07-12 10:31:00 EDT

Fixed by proper implementation of FocusCellOwnerDrawHighlighter#removeSelectionInformation. Did some improvements in FocusCellOwnerDrawHighlighter#focusCellChanged a well.

Comment 2 Ivan Furnadjiev

2011-10-10 07:14:07 EDT

Created attachment 204868 [details]
Proposed patch for v14_Maintenance branch

Comment 3 Ivan Furnadjiev

2011-10-10 07:19:09 EDT

Applied patch to v14_Tree_Table_Merge branch.

Comment 4 Ivan Furnadjiev

2011-10-10 16:31:44 EDT

Based on the comment in bug 261647 comment #3 the attached patched became obsolete. I've open a separate bug 360483 to clean up the selection coloring from FocusCellOwnerDrawHighlighter.