Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 351594

Summary:

NPE : when we try to merge a UML Property typed with a Class

Product:

[Modeling] EMFCompare

Reporter:

Vincent Lorenzo <vincent.lorenzo>

Component:

Core

Assignee:

EMF Compare <emf.compare-inbox>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

cedric.brun, laurent.goubet

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

351593

Bug Blocks:

Attachments:

Description	Flags
An exemple to reproduce this bug	none

Description Vincent Lorenzo

2011-07-08 11:43:18 EDT

It's difficult to explain how to reproduce this bug, so I provide an example in the attachement. (Explanations in the next comment).

Comment 1 Vincent Lorenzo

2011-07-08 11:49:37 EDT

Created attachment 199350 [details]
An exemple to reproduce this bug

Steps to reproduce : 
	1/ Compare the 2 uml files
	2/ Expand the Model model
	3/ Expand the Class Class0
	4/ Select the property 

You get the following exception : 
java.lang.NullPointerException
	at org.eclipse.emf.edit.provider.ComposedAdapterFactory.adapt(ComposedAdapterFactory.java:340)
	at org.eclipse.emf.edit.provider.ComposedAdapterFactory.adapt(ComposedAdapterFactory.java:277)
	at org.eclipse.emf.compare.util.AdapterUtils.adapt(AdapterUtils.java:55)
	at org.eclipse.emf.compare.util.AdapterUtils.getItemProviderImage(AdapterUtils.java:79)
	at org.eclipse.emf.compare.diff.provider.UpdateReferenceItemProvider.getImage(UpdateReferenceItemProvider.java:58)
	at org.eclipse.emf.edit.ui.provider.AdapterFactoryLabelProvider.getImage(AdapterFactoryLabelProvider.java:336)
	at org.eclipse.emf.compare.ui.viewer.structure.ModelStructureMergeViewer$ModelStructureLabelProvider.getImage(ModelStructureMergeViewer.java:440)
	at org.eclipse.jface.viewers.WrappedViewerLabelProvider.getImage(WrappedViewerLabelProvider.java:117)
	at org.eclipse.jface.viewers.WrappedViewerLabelProvider.update(WrappedViewerLabelProvider.java:165)
	at org.eclipse.jface.viewers.ViewerColumn.refresh(ViewerColumn.java:152)
	at org.eclipse.jface.viewers.AbstractTreeViewer.doUpdateItem(AbstractTreeViewer.java:938)
	at org.eclipse.jface.viewers.AbstractTreeViewer$UpdateItemSafeRunnable.run(AbstractTreeViewer.java:106)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:49)
	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:175)
	at org.eclipse.jface.viewers.AbstractTreeViewer.doUpdateItem(AbstractTreeViewer.java:1018)
	at org.eclipse.jface.viewers.StructuredViewer$UpdateItemSafeRunnable.run(StructuredViewer.java:485)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:49)
	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:175)
	at org.eclipse.jface.viewers.StructuredViewer.updateItem(StructuredViewer.java:2167)
	at org.eclipse.jface.viewers.AbstractTreeViewer.createTreeItem(AbstractTreeViewer.java:833)
	at org.eclipse.jface.viewers.AbstractTreeViewer$1.run(AbstractTreeViewer.java:808)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
	at org.eclipse.jface.viewers.AbstractTreeViewer.createChildren(AbstractTreeViewer.java:782)
	at org.eclipse.jface.viewers.TreeViewer.createChildren(TreeViewer.java:644)
	at org.eclipse.jface.viewers.AbstractTreeViewer.internalExpandToLevel(AbstractTreeViewer.java:1755)
	at org.eclipse.jface.viewers.AbstractTreeViewer.internalExpandToLevel(AbstractTreeViewer.java:1765)
	at org.eclipse.jface.viewers.AbstractTreeViewer.internalExpandToLevel(AbstractTreeViewer.java:1765)
	at org.eclipse.jface.viewers.AbstractTreeViewer.internalExpandToLevel(AbstractTreeViewer.java:1765)
	at org.eclipse.jface.viewers.AbstractTreeViewer.internalExpandToLevel(AbstractTreeViewer.java:1765)
	at org.eclipse.jface.viewers.AbstractTreeViewer.expandToLevel(AbstractTreeViewer.java:1060)
	at org.eclipse.jface.viewers.AbstractTreeViewer.expandToLevel(AbstractTreeViewer.java:1041)
	at org.eclipse.jface.viewers.AbstractTreeViewer.expandAll(AbstractTreeViewer.java:1030)
	at org.eclipse.emf.compare.ui.viewer.structure.ModelStructureMergeViewer$ConfigurationPropertyListener.propertyChange(ModelStructureMergeViewer.java:385)
	at org.eclipse.compare.CompareConfiguration.fireChange(CompareConfiguration.java:367)
	at org.eclipse.compare.CompareConfiguration.setProperty(CompareConfiguration.java:398)
	at org.eclipse.emf.compare.ui.viewer.content.part.ModelContentMergeTabFolder.navigateToDiff(ModelContentMergeTabFolder.java:257)
	at org.eclipse.emf.compare.ui.viewer.content.ModelContentMergeViewer.setSelection(ModelContentMergeViewer.java:355)
	at org.eclipse.emf.compare.ui.viewer.content.ModelContentMergeViewer.setSelection(ModelContentMergeViewer.java:341)
	at org.eclipse.emf.compare.ui.viewer.content.part.ModelContentMergeTabFolder$7.widgetSelected(ModelContentMergeTabFolder.java:560)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:240)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4165)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3754)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494)
	at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:123)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1386)

Comment 2 Vincent Lorenzo

2011-07-08 11:50:18 EDT

(In reply to comment #1)
> Created attachment 199350 [details]
(1) I, Vincent Lorenzo, wrote 100% of the code I've provided. 
(2) This code contains no cryptography 
(3) I have the right to contribute the code to Eclipse. 
(4) I contribute the content under the EPL.

Comment 3 Laurent Goubet

2011-07-20 03:19:31 EDT

This is an application of the "generic use case" that I describe in bug 351593, comment #1 . It will require the same kind of fix.

Comment 4 Laurent Goubet

2011-09-27 10:32:07 EDT

This has to be confirmed now with the changes for bug 351593 applied.

Comment 5 Cedric Brun

2011-10-11 09:33:00 EDT

I just did the check with the current master tree (eefaf5e570f20c2b5ec1b6304b0d84c195b7023d) and everything works as expected.

Comment 6 Laurent Goubet

2011-10-25 05:38:18 EDT

Thanks Cedric, closing now.