Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 351527

Summary: [ToolBar] Toolbar freezes Application
Product: [RT] RAP Reporter: Tim Buschtoens <tbuschto>
Component: RWTAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: tbuschto
Version: 1.5   
Target Milestone: 1.5 M1   
Hardware: All   
OS: All   
Whiteboard: sr141
Attachments:
Description Flags
fix for 1.4.1 none

Description Tim Buschtoens CLA 2011-07-08 04:52:07 EDT 
Just go to the conrols demos toolar tab. Browser freezes.
This seems to  be a side-effect of the introduction of fixed table-columns.
Comment 1 Tim Buschtoens CLA 2011-07-08 05:54:05 EDT 
Fixed by removing these lines from Request.js#_handleCompleted:

while( qx.ui.core.Widget._autoFlushTimeout !== null ) {
  // NOTE [tb] : a flush can schedule more flushes, which need to be executed 
  //             immediately to prevent flickering in certain cases
  qx.ui.core.Widget.flushGlobalQueues();
}

It's important to note that:
a) This re-introduces flickering in case of turning fixed columns on/off.
b) My researach indicates that the Toolbar still causes an infinite amout of flushes, it only doesnt freeze the browser anymore. As such the bug is not entirely fixed, the cause of the problem is still there.
Comment 2 Tim Buschtoens CLA 2011-07-08 07:18:30 EDT 
Fixed for good in MultiCellWidget.js:

Calling setCellWidth caused the widget to schedule a re-layout, even if it was not necessary. Fixed by checking the current value first.
Comment 3 Tim Buschtoens CLA 2011-07-22 06:09:09 EDT 
Created attachment 200166 [details]
fix for 1.4.1
Comment 4 Tim Buschtoens CLA 2011-08-22 09:40:28 EDT 
Commited patch(attachment 200166 [details]) to CVS v14_Maintenance branch.
Comment 5 Tim Buschtoens CLA 2011-08-25 08:56:55 EDT 
Applied patch to v14_Tree_Table_Merge branch.