Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 351472

Summary:

fix horizontal layout issue with attribute editor decorators

Product:

z_Archived

Reporter:

Thomas Ehrnhoefer <thomas.ehrnhoefer>

Component:

Mylyn

Assignee:

Thomas Ehrnhoefer <thomas.ehrnhoefer>

Status:

RESOLVED FIXED

QA Contact:

Severity:

minor

Priority:

CC:

steffen.pingel

Version:

unspecified

Keywords:

contributed

Target Milestone:

3.7

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
mylyn/context/zip	none

Description Thomas Ehrnhoefer

2011-07-07 12:17:54 EDT

some attribute editors (e.g. DoubleAttributeEditor) support decorators and validate input. The margins are too tight though. This should most likely be applied to all parts (if it's not in the abstract part anyway)

Comment 1 Steffen Pingel

2011-07-15 20:05:43 EDT

It looks like the layout is configured for a margin of 7 pixels but the text field border probably eats away one pixel: attributesLayout.horizontalSpacing = 7. Would you be able to provide a patch that sets this to the proper margin?

Comment 2 Thomas Ehrnhoefer

2011-07-18 16:10:42 EDT

So 2 px do the trick (in line #201 of TaskAttributeEditorPart)
However I have no clue how I would send a contribution / patch with git or egit, so why don't you change that number yourself Steffen :)

Comment 3 Steffen Pingel

2011-07-18 18:16:57 EDT

Thanks. I have adjusted the value accordingly.

Comment 4 Steffen Pingel

2011-07-18 18:17:00 EDT

Created attachment 199866 [details]
mylyn/context/zip