Bug 351441

Comment 1 Deepak Azad 2011-07-07 10:38:55 EDT

In the following snippet select void (the return type), and exit points will be marked including the closing } of twr and resource constructors. These are not marked when Throwable is selected in the throws clause.
--------------------------------------------------------------------------------
	void foo5() throws Throwable {
		FileReader reader = new FileReader("file1");
		try (FileReader reader1 = new FileReader("file1");
				FileReader reader2 = new FileReader("file2")) {
			int ch;
			while ((ch = reader1.read()) != -1) {
				reader.read();
			}
		}
	}
--------------------------------------------------------------------------------

While looking into this I also ran into an older issue. In the following snippet select 'Exception' in the throws clause => all three throw statements are marked even though 2 of the exceptions are caught. This is slightly different (and simpler to fix) than bug 75878 and bug 68305.
----------------------------------------------------------------------------
	void foo(String s) throws Exception {
		try {
			if (s == null)
				throw new NullPointerException();
			else if (s.length() > 10)
				throw new IllegalArgumentException();
			else
				throw new Exception();
		} catch (NullPointerException e) {
			e.printStackTrace();
		} catch (IllegalArgumentException e) {
			e.printStackTrace();
		}
	}
----------------------------------------------------------------------------

Comment 2 Markus Keller 2011-07-07 10:51:34 EDT

Looks the same as bug 68305. Here, the outer scope is the "throws" clause whereas in bug 68305, it's the outer "try" statement. Necessary analysis is exactly the same.

Comment 3 Deepak Azad 2011-07-09 01:31:34 EDT

Created attachment 199369 [details]
fix + test

(In reply to comment #1)
> In the following snippet select void (the return type), and exit points will be
> marked including the closing } of twr and resource constructors. These are not
> marked when Throwable is selected in the throws clause.
> --------------------------------------------------------------------------------
>     void foo5() throws Throwable {
>         FileReader reader = new FileReader("file1");
>         try (FileReader reader1 = new FileReader("file1");
>                 FileReader reader2 = new FileReader("file2")) {
>             int ch;
>             while ((ch = reader1.read()) != -1) {
>                 reader.read();
>             }
>         }
>     }
> --------------------------------------------------------------------------------

For now I have fixed the above problem. Bug 68305 is an older issue, which I think we should fix for 3.7.1.

Comment 4 Deepak Azad 2011-07-09 01:36:20 EDT

.

Comment 5 Ayushman Jain 2011-07-20 02:56:02 EDT

Verified using JDT feature patch v20110714-1300.