Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 351435

Summary: org.eclipse.rse.subsystems.files.core.SystemIFileProperties.getBIDILogical() should default to true
Product: [Tools] Target Management Reporter: Edmund Reinhardt <reinhard>
Component: RSEAssignee: David McKnight <dmcknigh>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: normal    
Priority: P3 CC: dmcknigh, reinhard, xuanchen
Version: unspecifiedFlags: xuanchen: review+
Target Milestone: 3.3.1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 351449    
Attachments:
Description Flags
patch to return true by default for getBIDILogical() none

Description Edmund Reinhardt CLA 2011-07-07 08:26:50 EDT 
By default all files are stored in logical, so this should default to true, if this property has not been set.
The only time it is visual is in some edge cases (WebFacing conversion of DDS, event files) where transient files are downloaded in visual to avoid breaking syntax.

If a project is shared in RTC and then loaded into another workspace this property is not set, and should default to true, which is always correct (since transient files are not shared in RTC).
Comment 1 Edmund Reinhardt CLA 2011-07-07 08:29:28 EDT 
Dave, please take ownership as we discussed.  It would be nice if this was in the IES that is picked up in this release.
Comment 2 David McKnight CLA 2011-07-07 09:51:11 EDT 
(In reply to comment #1)
> Dave, please take ownership as we discussed.  It would be nice if this was in
> the IES that is picked up in this release.

I've created bug 351449 for the backport to RSE 3.2.x (i.e. the one that would get picked up via IES).
Comment 3 David McKnight CLA 2011-07-07 09:51:57 EDT 
Created attachment 199266 [details]
patch to return true by default for getBIDILogical()
Comment 4 David McKnight CLA 2011-07-07 09:52:59 EDT 
Kevin, could you please review this patch?
Comment 5 Edmund Reinhardt CLA 2011-07-07 11:30:26 EDT 
Dave, would you mind opening a task on Eric Simpson so that this bug will be picked up in time in IES
Comment 6 David McKnight CLA 2011-07-08 10:30:23 EDT 
Xuan, could you please review this patch?
Comment 7 Xuan Chen CLA 2011-07-08 10:35:31 EDT 
The fix looks good.  Thanks.
Comment 8 David McKnight CLA 2011-07-08 10:46:31 EDT 
Thanks for the review, Xuan.  I've committed the change to the HEAD stream.
Comment 9 Martin Oberhuber CLA 2011-07-18 11:34:38 EDT 
Released > I20110718, tagged as R33x_v201107181530