Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 351368

Summary:

Error handling of opcontrol needs improvement

Product:

z_Archived

Reporter:

Corey Ashford <cjashfor>

Component:

LinuxTools

Assignee:

Severin Gehwolf <sgehwolf>

Status:

CLOSED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

kksebasti, overholt, sgehwolf, wainersm

Version:

unspecified

Target Milestone:

---

Hardware:

All

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
Patch to improve error handling of opcontrol	jjohnstn: iplog+

Description Corey Ashford

2011-07-06 15:34:46 EDT

Build Identifier: I20110613-1736

When opcontrol is invoked, if it returns an error, the error isn't handled in a transparent way for the user.  In order to find the error message emitted by opcontrol, the user must have had the debug switch turned on for this plug-in.  Additionally, the dialog message that pops up is quite misleading.

If you do know that you can turn on the debug switch, instead of the output going to a conventional place in the SDK, such as the Error Log, it goes to the console, which might be hard to notice, particularly if Eclipse was started using a desktop icon.

Reproducible: Always

Steps to Reproduce:
1. Intentionally make an error in the Profile configuration that will cause opcontrol to emit an error message and return with a non-zero error code.
2. Notice the misleading dialog, and lack of actual output from opcontrol

Comment 1 Corey Ashford

2011-07-06 15:37:56 EDT

Created attachment 199204 [details]
Patch to improve error handling of opcontrol

See additional comments in the actual patch file.

Comment 2 Severin Gehwolf

2011-07-06 17:27:11 EDT

Pushed with e99ec70f8861245c752fbcca5527e3eee7d7096e. Thanks! Let us know if there are more issues.

Comment 3 Corey Ashford

2011-07-06 17:39:09 EDT

Thanks for having a look at and committing this patch so quickly :-)

Comment 4 Andrew Overholt

2011-08-15 14:38:28 EDT

Has this been cherry-picked to stable-0.8?

Comment 5 Severin Gehwolf

2011-08-15 14:48:46 EDT

(In reply to comment #4)
> Has this been cherry-picked to stable-0.8?

No, will do today.

Comment 6 Severin Gehwolf

2011-08-16 14:28:14 EDT

(In reply to comment #5)
> (In reply to comment #4)
> > Has this been cherry-picked to stable-0.8?
> 
> No, will do today.

Done. Longer day than I thought ;-)

Comment 7 Jeff Johnston

2011-09-21 16:08:39 EDT

Comment on attachment 199204 [details]
Patch to improve error handling of opcontrol

Less than 250 lines.