Bugzilla – Full Text Bug Listing
| Summary: | [Compatibility] Toolbar ordering is off in 'Git Repositories' view | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Remy Suen <remy.suen> | ||||||||
| Component: | UI | Assignee: | Remy Suen <remy.suen> | ||||||||
| Status: | VERIFIED FIXED | QA Contact: | Remy Suen <remy.suen> | ||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | pwebster | ||||||||
| Version: | 4.1 | ||||||||||
| Target Milestone: | 4.2 M3 | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 331240 | ||||||||||
| Attachments: |
|
||||||||||
It almost feels like we need a specialized subclass of ToolBarManager here. Right now we have no way of knowing when someone adds or removes contribution items so it is not possible for us to determine when we should reconcile its list of items with the model's collection of opaque items. From a compat point of view, we have 2 points where we can reconcile the toolbar: 1) after the createPartControl(*) is called 2) after actionBars.updateActionBars() is called. Views are not allowed to add things to their toolbar unless they call updateActionBars() (outside of createPartControl(*)) PW Created attachment 199590 [details]
ToolBar rendering patch v1
Paul, what do you think of this?
Created attachment 203145 [details]
ToolBar rendering patch v2
Ordering is also bad in the 'Breakpoints' view. Fix pushed to R4_development. http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_development&id=726f6f1497195c8851342c8fe2dcaffa79e8da3e Verified with I20111025-2000 on Windows XP. |
Created attachment 199195 [details] Screenshot depicting the problem in question. We have two items at the end of the toolbar instead of the front. From a cursory analysis it looks like we don't have opaque model items representing those items.