Bug 351255

Comment 1 Chris Recoskie 2011-07-25 09:48:45 EDT

At one time we needed to have an Eclipse dynamic variable defined in addition to the managed build system macro resolver because makefile projects didn't have a toolchain, and hence had no way of resolving the variable for scanner discovery.  Now that makefile projects have a toolchain, we can get rid of this.

Even still, this ought to have worked.  Something changed in the build system at some point to cause Eclipse variables to be evaluated first and then evaluate build macros after that.  It used to be the other way around.

Regardless, I'll post (as well as commit) the patch today that fixes this.  I've confirmed that getting rid of the dynamic variable resolver and variable definition fixes the problem.  Makefile projects still function after the fix.

Comment 2 Chris Recoskie 2011-07-25 12:33:08 EDT

Created attachment 200294 [details]
patch

Comment 3 Vivian Kong 2011-07-26 10:19:47 EDT

(In reply to comment #2)
> Created attachment 200294 [details]
> patch

I don't think we need to update the version number again.  I believe I've already updated it to 6.2.0 for bug 350501

Comment 4 Chris Recoskie 2011-07-26 15:38:13 EDT

Created attachment 200391 [details]
patch that fixes version number

Comment 5 Chris Recoskie 2011-07-26 17:12:06 EDT

Applied to cdt_7_0, cdt_8_0, and master.

Comment 6 CDT Genie 2011-07-26 17:18:33 EDT

*** cdt git genie on behalf of 351255 ***

    Bug 353113 - BuildDescription class does not behave properly for remote
    projects
commit 673d559f90b08f6995fabc8b8bd6cc79e3c757c0
    Bug 351255 - Generated makefile should use user specified compiler path
    instead of workspace preference

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=983c100d63dd2fa8372ccdae0585af74e886c848
[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=673d559f90b08f6995fabc8b8bd6cc79e3c757c0

Comment 7 CDT Genie 2011-07-26 17:18:35 EDT

*** cdt git genie on behalf of 351255 ***

    Bug 351255 - Generated makefile should use user specified compiler path
    instead of workspace preference
commit 79fc7de8028144434f8e7d1bcea741548b117fa7
    Bug 353113 - BuildDescription class does not behave properly for remote
    projects
commit 2b7373ef4c8f8d31ea7ac1f23e22a30ecf3cb915
    Bug 351255 - Generated makefile should use user specified compiler path
    instead of workspace preference

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=e40f22522228b215a416d16ec5a3b7a513cbcb37
[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=79fc7de8028144434f8e7d1bcea741548b117fa7
[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=2b7373ef4c8f8d31ea7ac1f23e22a30ecf3cb915

Comment 8 CDT Genie 2011-07-26 18:18:33 EDT

*** cdt git genie on behalf of 351255 ***

    Bug 353113 - BuildDescription class does not behave properly for remote
    projects
commit 43acd6a0f8e1cbe0fb7aa0a8f343bf69011583fa
    Bug 351255 - Generated makefile should use user specified compiler path
    instead of workspace preference

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=a8fb1e337610bb7dbfd1d70639770f7f07746bf3
[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=43acd6a0f8e1cbe0fb7aa0a8f343bf69011583fa

Comment 9 CDT Genie 2012-03-23 14:54:01 EDT

*** cdt git genie on behalf of Chris Recoskie ***

    Bug 351255 - Generated makefile should use user specified compiler path
    instead of workspace preference

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=2b7373ef4c8f8d31ea7ac1f23e22a30ecf3cb915