Bugzilla – Full Text Bug Listing
| Summary: | Odd view tab resizing | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Andrew Overholt <overholt> | ||||
| Component: | UI | Assignee: | Eric Moffatt <emoffatt> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | emoffatt | ||||
| Version: | 4.1 | ||||||
| Target Milestone: | 4.2 M4 | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Andrew Overholt
On Windows 7 the Outline seems to have a minimum size beyond which it won't shrink, but on Mac I see exactly the same behavior as in your video. (In reply to comment #0) > (and I don't know if the viewer of this bug can view webm videos :) : Seems to be fine with Firefox, thanks for making this video - otherwise it would have been hard to understand. M2 is done... Still happening for me with 4.2M2 on Linux Gtk. This is likely connected to our (lack of) use of CTF's 'setMinimumCharacters' API. IIRC in 3.x it's set to 1 for ViewStacks and some larger value for editor stacks. We should at least see if setting the default value to '1' when a stack that is *outside* the shared area is rendered (and some other larger number otherwise). Eric says to set this to M4. He also thinks it's an SWT issue :) I've just tried setting the min characters to 1 (and 0). While the resizing works as expected if there's enough room for at least one tab to be drawn within the given settings we can still resize the stack horizontally to the point where the tab disappears (a la Andrew's image). Not really sure what to do here. I could try to constrain the minimum width of a stack but really don't know when it should stop shrinking (i.e. I can't really detect when we're in the situation described here). I'm going to use this defect for now to at least commit the changes to set the minimum chars to 1. I'll check with Bogdan to see what else we can do...
Pushed in >20111109.
commit 43046783b41c805748d62cec80bd87f36bbb05e1
This should get us much closer to the 3.x behavior. CTF's inside the editor area show at least 15 chars and only 1 if they aren't in the shared area.
It also adjusts the 'setUnselectedCloseVisible' to get back even more space in stacks outside the shared area (i.e. 'view' stacks).
Andrew, I'm going to close this even though your original scenario still exists. I went over it with Bogdan and we can demonstrate the same behavior in 3.x; when there just isn't enough pixels to show even one tab there really isn't much we can do...this is a case of DIH ("Doctor it hurts..."), don't make the window so small if you want to avoid this issue...;-).
Thanks, Eric :) Verified in I20111205-2330. |