Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 351184

Summary: [Gogo] vsh bundle list shows incorrect list
Product: [RT] Virgo Reporter: Glyn Normington <glyn.normington>
Component: runtimeAssignee: Hristo Iliev <hsiliev>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: l.kirchev
Version: 3.0.0.M06   
Target Milestone: 3.0.0.RC1   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
Patch that fixes the IDs of the listed with vsh bundles
none
Fixes the IDs of the listed with vsh bundles
none
Patch for the problem
none
Patch for the problem none

Description Glyn Normington CLA 2011-07-05 09:11:37 EDT 
The bundle ids look wrong at the very least. Once these are fixed, we should check that the list is consistent and work out why some bundles are missing.

Compare:
osgi> vsh bundle list

Id   Name                                       Version                    State
7    org.eclipse.osgi.services                  3.3.0.v20110110           ACTIVE
8    org.eclipse.equinox.cm                     1.0.300.v20101204         ACTIVE
20   org.springframework.aop                    3.0.5.RELEASE             ACTIVE
21   org.springframework.asm                    3.0.5.RELEASE             ACTIVE
22   org.springframework.expression             3.0.5.RELEASE             ACTIVE
23   org.springframework.beans                  3.0.5.RELEASE             ACTIVE
24   org.springframework.core                   3.0.5.RELEASE             ACTIVE
25   org.springframework.context                3.0.5.RELEASE             ACTIVE
27   org.eclipse.virgo.kernel.agent.dm          3.0.0.M06                 ACTIVE
28   org.springframework.osgi.core              1.2.1                     ACTIVE
29 S org.springframework.osgi.extender          1.2.1                     ACTIVE
30   org.springframework.osgi.io                1.2.1                     ACTIVE
31   com.springsource.org.aopalliance           1.0.0                     ACTIVE
32   org.eclipse.equinox.ds                     1.3.0.v20110124-0830      ACTIVE
33   org.eclipse.equinox.util                   1.0.200.v20100503         ACTIVE
40   org.eclipse.virgo.kernel.userregionfactory 3.0.0.M06                 ACTIVE
41   com.springsource.org.apache.mina.core      2.0.2                     ACTIVE
42   org.apache.felix.gogo.command              0.8.0.v201105062003       ACTIVE
43   org.apache.felix.gogo.runtime              0.8.0.v201105062003       ACTIVE
44   org.apache.felix.gogo.shell                0.8.0.v201105062003       ACTIVE
45   org.eclipse.equinox.console.supportability 1.0.0.N20110626-2000      ACTIVE
46   com.springsource.org.apache.sshd.core      0.5.0                     ACTIVE
48   org.eclipse.virgo.kernel.userregion        3.0.0.M06                 ACTIVE
49   org.eclipse.virgo.kernel.osgicommand       3.0.0.M06                 ACTIVE
61 S org.eclipse.virgo.kernel.deployer.dm       3.0.0.M06                 ACTIVE
65   org.eclipse.virgo.kernel.dmfragment        3.0.0.M06               RESOLVED

and:

osgi> ss
"Framework is launched."


id	State       Bundle
0	ACTIVE      org.eclipse.osgi_3.7.0.v20110224
40	ACTIVE      org.eclipse.virgo.kernel.userregionfactory_3.0.0.M06
47	ACTIVE      org.eclipse.equinox.cm_1.0.300.v20101204
48	ACTIVE      org.eclipse.virgo.kernel.userregion_3.0.0.M06
49	ACTIVE      org.eclipse.virgo.kernel.osgicommand_3.0.0.M06
50	ACTIVE      org.eclipse.osgi.services_3.3.0.v20110110
51	ACTIVE      com.springsource.org.apache.mina.core_2.0.2
52	ACTIVE      org.apache.felix.gogo.command_0.8.0.v201105062003
53	ACTIVE      org.apache.felix.gogo.runtime_0.8.0.v201105062003
54	ACTIVE      org.apache.felix.gogo.shell_0.8.0.v201105062003
55	ACTIVE      org.eclipse.equinox.console.supportability_1.0.0.N20110626-2000
56	ACTIVE      com.springsource.org.apache.sshd.core_0.5.0
57	ACTIVE      org.springframework.osgi.core_1.2.1
58	ACTIVE      org.springframework.osgi.extender_1.2.1
	            Fragments=65
59	ACTIVE      org.springframework.osgi.io_1.2.1
60	ACTIVE      org.eclipse.virgo.kernel.agent.dm_3.0.0.M06
61	ACTIVE      org.eclipse.virgo.kernel.deployer.dm_3.0.0.M06
62	ACTIVE      org.eclipse.equinox.ds_1.3.0.v20110124-0830
63	ACTIVE      org.eclipse.equinox.util_1.0.200.v20100503
64	ACTIVE      com.springsource.org.aopalliance_1.0.0
65	RESOLVED    org.eclipse.virgo.kernel.dmfragment_3.0.0.M06
	            Master=58
66	ACTIVE      org.springframework.aop_3.0.5.RELEASE
67	ACTIVE      org.springframework.asm_3.0.5.RELEASE
68	ACTIVE      org.springframework.beans_3.0.5.RELEASE
69	ACTIVE      org.springframework.context_3.0.5.RELEASE
70	ACTIVE      org.springframework.core_3.0.5.RELEASE
71	ACTIVE      org.springframework.expression_3.0.5.RELEASE
Comment 1 Glyn Normington CLA 2011-07-05 09:13:56 EDT 
It appears as if bundles which are present in both the kernel and user region are displaying their kernel bundle ids in the list.
Comment 2 Glyn Normington CLA 2011-07-19 04:47:12 EDT 
Targeting 3.0.0.RC1 to indicate this bug is a "must fix".
Comment 3 Glyn Normington CLA 2011-07-19 07:31:38 EDT 
Assigning to Lazar/Borislav.
Comment 4 Borislav Kapukaranov CLA 2011-07-20 03:11:13 EDT 
Created attachment 199954 [details]
Patch that fixes the IDs of the listed with vsh bundles

This patch fixes the vsh bundle list. The problem was that vsh got the whole bundles list via the quasi framework and searched with bsn and version for bundles in it, so it took the IDs of the first matches. That is why the bundles that are present in both regions were listed with their kernel ID. Fixed by checking if the matched ID is present in the user region's bundleIDs list, if not continue matching.
Comment 5 Borislav Kapukaranov CLA 2011-07-20 03:12:00 EDT 
Assigning to Hristo as he showed interest in integrating this in Virgo.
Comment 6 Hristo Iliev CLA 2011-07-20 04:13:45 EDT 
Created attachment 199959 [details]
Fixes the IDs of the listed with vsh bundles
Comment 7 Lazar Kirchev CLA 2011-07-20 06:07:16 EDT 
Created attachment 199967 [details]
Patch for the problem
Comment 8 Lazar Kirchev CLA 2011-07-20 06:57:56 EDT 
Created attachment 199973 [details]
Patch for the problem
Comment 9 Hristo Iliev CLA 2011-07-20 07:28:20 EDT 
Lazar can you confirm that you wrote 100% of the code and you have the right to contribute it to Eclipse?
Comment 10 Lazar Kirchev CLA 2011-07-20 07:39:39 EDT 
(In reply to comment #9)
> Lazar can you confirm that you wrote 100% of the code and you have the right to
> contribute it to Eclipse?

Yes, I confirm that.
Comment 11 Hristo Iliev CLA 2011-07-20 08:51:32 EDT 
Patch commit id: 73644c6f41c9bb6f4bf292df4c6de2fa98626127