Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 351157

Summary:	Codan Source Plugin has incorrect Bundle-Name / Bundle-Vendor
Product:	[Tools] CDT	Reporter:	Martin Oberhuber <mober.at+eclipse>
Component:	cdt-releng	Assignee:	cdt-releng-inbox <cdt-releng-inbox>
Status:	NEW ---	QA Contact:	Jonah Graham <jonah>
Severity:	normal
Priority:	P3	CC:	cdtdoug, elaskavaia.cdt
Version:	8.0
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:	351289
Bug Blocks:

Description Martin Oberhuber

2011-07-05 06:04:23 EDT

Build ID: CDT 8.0 (Indigo)

Doing Help > About : Installed Software with CDT 8.0 installed, shows following feature on top of the list:

  %Bundle-Name Source   
  1.0.0.201106081058   
  org.eclipse.cdt.codan.checkers.ui.source
  %Bundle-Vendor

Since the source bundle is generated, it looks like the problem is in the respective binary bundle. In fact, in the

  org.eclipse.cdt.codan.checkers.ui

it looks like
  - plugin.properties file is missing
  - Bundle-Localization:plugin is missing in the MANIFEST.MF

Comment 1 Vivian Kong

2011-07-05 11:38:30 EDT

Alena, can you please take a look?  Thanks.

Comment 2 Elena Laskavaia

2011-07-05 21:46:18 EDT

It is in 
OSGI-INF/l10n/bundle.properties

not in plugin.properties and it is included.

I don't know if this should be Bundle-Localization, this code is generated
by eclipse, I assume it does not need that.

I don't know how source bundle generated

Comment 3 Elena Laskavaia

2011-07-05 21:47:57 EDT

Although "source bundle" tab looks wrong, I will add bunch of files there maybe it will help

Comment 4 Elena Laskavaia

2011-07-05 22:05:21 EDT

Adding stuff in source did not help - it generates warning that it should be added. I fixed warnings in build.properties regarding OSGI-INF. I still think somewhere is wrong with source build.

Comment 5 Martin Oberhuber

2011-07-06 05:34:25 EDT

Looks like you're right and there's an issue with the source bundle generator... I have filed bug 351289 asking PDE Build for advice.

Maybe the issue will go away when building from git with Tycho, since AFAIK Tycho uses its own mechanism for generating source.

Although it looks like the OSGI-INF way of bundle localization is default since Eclipse 3.5, it doesn't seem to be very widespread yet.

Comment 6 Martin Oberhuber

2011-07-07 10:04:24 EDT

I noticed that some JSDT source bundles have the same problem (e.g.
  org.eclipse.wst.jsdt.debug.rhino
) but usually the problem gets never visible, since source bundles are not shown in Help > About.

I guess I'll need to figure out why this bundle appeared under "Installed Software" for me since that's actually unexpected.