Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 351116

Summary:

[Tree] hover background sometimes disappears

Product:

[RT] RAP

Reporter:

Ralf Sternberg <rsternberg>

Component:

RWT

Assignee:

Project Inbox <rap-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

tbuschto

Version:

1.5

Target Milestone:

1.5 M1

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
Poposed patch	ivan: review?

Description Ralf Sternberg

2011-07-04 15:48:03 EDT

To reproduce, open the Complex Data tab in the examples demo.
* Move the cursor over the text of an item.
* Slowly move to the expand icon.
* Move back to the item text
-> hover color disappears

Comment 1 Ivan Furnadjiev

2011-07-22 04:57:56 EDT

It's better reproducible when moving the mouse from left (before the expand icon) to the right on the same item.

Comment 2 Ivan Furnadjiev

2011-07-22 06:21:27 EDT

Created attachment 200168 [details]
Poposed patch

This patch removes the check for hoverable in TreeRowContainer.js#_onElementOver. Tim, do you remember why this check was introduced? Is it save to remove it?

Comment 3 Tim Buschtoens

2011-07-22 07:06:35 EDT

This was probably an attempt to prevent unnecessary re-renderings of the item. The flaw in this logic is that for an elementOut event is rendered (no hover), but then not for the elementOver (which would have hover again). I think it can be savely remoed. The propper fix would be to check if the old hover-element was hoverable too.

Comment 4 Tim Buschtoens

2011-07-22 08:27:27 EDT

Fixed in CVS HEAD as ivan suggested. This might create a very small performance loss when hovering treeitems, but improving tree performance will be a different task for the future.