Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 351094

Summary: SSH2 Key Management Comment Field stuck on RSA-1024
Product: [Eclipse Project] Platform Reporter: Chad <chad>
Component: TeamAssignee: Atsuhiko Yamanaka <ymnk>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, pwebster, tomasz.zarna, ymnk
Version: 4.1   
Target Milestone: 3.8 M2   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
a patch to fix the reported problem. none

Description Chad CLA 2011-07-04 10:09:30 EDT 
Build Identifier: 20110301-1815

When creating or loading private keys into Eclipse in the Windows -> Preferences -> Network Connections -> SSH2 Window... Whenever an RSA public / private key pair is generated or loaded, the comment field is always "RSA-1024". Changing the comment field does not appear to change it in the key. Also, manually changing this field in a text editor, RSA-1024 will display when the key is loaded.

Reproducible: Always

Steps to Reproduce:
1. Open The Key Management tab in Windows -> Preferences -> Network Connections -> SSH2
2. Click the "Generate RSA Key..." or "Load Existing Key..." button (if you already have a public/private key pair)
3. Notice the "Comment:" text field below (it says RSA-1024)
4. Attempt to update the comment field and click "Save Private Key..."
5. Open public key in editor and notice that the field is still RSA-1024
Comment 1 Atsuhiko Yamanaka CLA 2011-07-06 04:34:53 EDT 
I have confirmed the problem, and I'll fix it.
Comment 2 Atsuhiko Yamanaka CLA 2011-07-08 02:45:38 EDT 
Created attachment 199308 [details]
a patch to fix the reported problem.

To fix the problem, this patch will do the followings,
  * saving the public-key with a modified comment,
  * retrieving a comment from the existing public-key.
Comment 3 Atsuhiko Yamanaka CLA 2011-07-08 02:51:42 EDT 
Chad or somebody, could you please try the attached patch?
If there is no problem, I'll commit it.
Comment 4 Tomasz Zarna CLA 2011-07-14 04:51:18 EDT 
(In reply to comment #3)
> Chad or somebody, could you please try the attached patch?
> If there is no problem, I'll commit it.

The patch looks good and works fine. Could you please just update the copyright section, apply formatting and add link to the bug in JSch API you mentioned in the TODO.
Comment 5 Tomasz Zarna CLA 2011-08-10 04:41:05 EDT 
Atsuhiko, could you please adjust your patch with the comment above? If you're too busy, I can fix the bug for you.
Comment 6 Atsuhiko Yamanaka CLA 2011-08-11 02:12:50 EDT 
(In reply to comment #5)
> Atsuhiko, could you please adjust your patch with the comment above? If you're
> too busy, I can fix the bug for you.

I have adjust the patch as you have suggested,
and committed to the repository.