Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 351042

Summary:	CommitIntegrityCheck should use #equals when comparing OIDs
Product:	[Modeling] EMF	Reporter:	Caspar D. <caspar_d>
Component:	cdo.core	Assignee:	Caspar D. <caspar_d>
Status:	CLOSED FIXED	QA Contact:	Eike Stepper <stepper>
Severity:	normal
Priority:	P3	CC:	saulius.tvarijonas
Version:	4.0	Flags:	stepper: review+
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Caspar D.

2011-07-04 00:50:39 EDT

*** Cloned from Bug 349526 ***

Comment 1 Eike Stepper

2011-07-04 03:43:18 EDT

I can still see checks like "currentContainerID != CDOID.NULL" and from the context I can not see that currentContainerID!=null. Don't you think it's worth fixing that to "!CDOIDUtil.isNull(currentContainerID)"?

Comment 2 Caspar D.

2011-07-04 05:28:42 EDT

Committed revision 8583.

(In reply to comment #1)
> I can still see checks like "currentContainerID != CDOID.NULL" and from the
> context I can not see that currentContainerID!=null. Don't you think it's worth
> fixing that to "!CDOIDUtil.isNull(currentContainerID)"?

As discussed on Skype, I can't oversee whether that truly
expresses the same condition under all circumstances. I'm not 
sure about this, and don't have time to look into it today :(

Comment 3 Caspar D.

2011-07-04 05:28:59 EDT

Resolving.

Comment 4 Eike Stepper

2012-09-21 06:50:24 EDT

Closing.