Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 350975

Summary: [performance] tune up constructor patch from bug 306958
Product: [WebTools] JSDT Reporter: Nitin Dahyabhai <thatnitind>
Component: GeneralAssignee: Nitin Dahyabhai <thatnitind>
Status: RESOLVED WONTFIX QA Contact: Nitin Dahyabhai <thatnitind>
Severity: minor    
Priority: P3 CC: itewksbu, mauromol
Version: 3.2.5   
Target Milestone: 3.2.5   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 306958, 350976    
Bug Blocks:    
Attachments:
Description Flags
proposed patch none

Description Nitin Dahyabhai CLA 2011-07-01 18:18:03 EDT
A few additional changes on top of those in bug 306958:
-updated build.properties for the test project zip
-optimization to changes in o.e.w.jsdt.internal.compiler.util.Util#getTypeName(IExpression) so it doesn't create lots of extra strings
-remove some redundant lines in ConstructorDeclarationPattern Ian and I found during review
Comment 1 Nitin Dahyabhai CLA 2011-07-01 18:19:58 EDT
Created attachment 198989 [details]
proposed patch
Comment 2 Nitin Dahyabhai CLA 2011-07-05 10:15:52 EDT
The addition of the test zip to the build.properties wasn't captured in the patch due to the file being set to Binary at the time.
Comment 3 Nitin Dahyabhai CLA 2011-09-01 14:08:55 EDT
.