Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 350848

Summary:

PDT doc plugin should include a pre-built help index

Product:

z_Archived

Reporter:

Martin Oberhuber <mober.at+eclipse>

Component:

PDT

Assignee:

PHP Doc <php.doc-inbox>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

jacek.pospychala, kalin.a, zhaozhongwei

Version:

unspecified

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch providing a prebuilt doc index	none

Description Martin Oberhuber

2011-06-30 10:51:58 EDT

Created attachment 198915 [details]
Patch providing a prebuilt doc index

+++ This bug was initially created as a clone of Bug #350828 +++

When searching Eclipse Help for the first time, a search index has to be built. The speed of doing so can be drastically improved when the doc plugin ships a prebuilt help index. 

PDT help should include such an index, such that adopters can search docs faster.

Attached patch adds the pre-built index to the docs when building them.
Please consider for inclusion.

Comment 1 Martin Oberhuber

2011-07-29 12:34:30 EDT

Ping, could my patch be considered ?

Comment 2 Martin Oberhuber

2011-09-07 07:38:40 EDT

Ping, could my patch be considered please?

This is really just a minimal change with measurable performance gain.

Comment 3 Zhongwei Zhao

2011-09-07 08:04:14 EDT

hi,

I will have a look at the patch,thanks for your contribution!

Comment 4 Martin Oberhuber

2011-11-16 15:15:42 EST

Ping, has this been checked in by now ?

Comment 5 Martin Oberhuber

2012-01-24 04:31:49 EST

Ping, could my patch please be checked in ? SR2 is almost there...

Comment 6 Jacek Pospychala

2012-01-24 07:18:40 EST

hi Martin,
sorry for late response.

I applied your patch with slight modification (change to plugin.xml was not matching cleanly to HEAD) and invoked a new build to see if index is getting generated properly.

thanks for your patience!

Comment 7 Jacek Pospychala

2012-01-24 07:45:27 EST

Build is done, index folder gets generated, but it's empty.
That's probably because PDT help content were recently moved from plugin to the web to make plugin more lightweight.

Comment 8 Martin Oberhuber

2012-01-24 10:16:27 EST

Hmm, how is help search expected to work when content is on the web only ?

Comment 9 Jacek Pospychala

2012-01-25 04:37:38 EST

I guess it doesn't.
Opened #369635

Comment 10 Kalin

2012-07-05 10:14:43 EDT

Verified fixed.
Closing...

Kalin Yanev
kalin.a@zend.com