Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 350787

Summary:	[All Diagrams] Format and Filter popup menu items sometimes duplicated, depending on context
Product:	[Modeling] Papyrus	Reporter:	Alain Le Guennec <alain.leguennec>
Component:	Core	Assignee:	Vincent Lorenzo <vincent.lorenzo>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	eclipse-bugzilla
Version:	0.8.0
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Alain Le Guennec

2011-06-30 05:04:44 EDT

On SysML Block Definition Diagram and Internal Block Diagram (at least), it is possible to have duplicated popup menu items for the Format or Filter sub-menus:
-If the *label* of a port is selected, then the "Format" menu items is displayed twice, with two different contents that should probably be merged.
-If a compartment of a symbol (such as a block or a part) is selected (and not the symbol as a whole), then the "Filter" menu item is displayed twice. This notably occurs for the "structure" compartment of the main block on the IBD diagram. Again, the two different sub-contents should probably be merged.

Note that in both context, one of the duplicated menu entries has the Papyrus icon, and the other doesn't. This suggests that one of the menu entries is contributed by Papyrus and the other by the underlying framework.

Comment 1 Vincent Lorenzo

2011-09-22 10:59:42 EDT

Hello Alain, 
  you are true, there is the initial Filter and Format Menus, provided by GMF and the Papyrus version of these menus. We rewrote them in the Eclipse Framework (org.eclipse.ui.menus). 
  Concerning the duplicated menu, it is because we forgot to rewrite an action in these menus and this action is only available when you do this type of selection.
  The actions are : 
  	- Show Compartment Title -> We should hide it, because Papyrus provide its own mecanism
  	- Snap back -> I need to investigate to know how it works and if I need to rewrite it.
  	
I could hide directly the GMF Filter/Format menu, but in this case, we wouldn't see easily if we forgot to rewrite some actions.

Comment 2 Vincent Lorenzo

2011-09-22 11:10:00 EDT

FYI : snap back allow to reset a label to its initial location. This action is available for Link label and External Node Label, but doesn't work with External Node Label.

Comment 3 Vincent Lorenzo

2011-09-23 08:52:00 EDT

Done on Branch in R5567, merged in R5569.

Comment 4 Vincent Lorenzo

2011-09-23 08:52:35 EDT

This bug can be marked as fixed and closed.

Comment 5 Vincent Lorenzo

2011-09-23 10:40:11 EDT

In R5573 : minor change : add a constraint on the visibility of Snap Back action : visible when activeEditorId is Papyrus!

(branch and trunk)