Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 350734

Summary:

Refresh Branches operation now fails when encountering certain files

Product:

[Eclipse Project] Platform

Reporter:

Neil Hauge <neil.hauge>

Component:

CVS

Assignee:

platform-cvs-inbox <platform-cvs-inbox>

Status:

CLOSED WONTFIX

QA Contact:

Severity:

normal

Priority:

CC:

david_williams, seven-mail

Version:

3.7

Target Milestone:

---

Hardware:

OS:

Windows 7

Whiteboard:

stalebug

Bug Depends on:

Bug Blocks:

350608

Attachments:

Description	Flags
Problematic file	none

Description Neil Hauge

2011-06-29 14:00:10 EDT

Created attachment 198850 [details]
Problematic file

After moving up from Helios to Indigo it was soon noticed that previously existing CVS branches in WTP could not be displayed for a particular module using Eclipse 3.7.  An exception was logged (1).  I entered bug 350608 as a result as I was unsure of the cause of this issue.  After doing some debugging I found that a particular file (attached) in our repository was causing the exception.  This file looked a bit questionable, but it hadn't caused problems in the past.  After some more digging, it appears that changes made for bug 76386 were the cause of this issue occurring only in 3.7.

In LogListener, line 199, the new call to this.getBranchRevision(revision) appears to assume that the revision will be an actual revision, and not a COMMENT of BRANCH_REVISION.  I don't claim to fully understand the workings of the containing method, but thought I would point out where the problem appears to be. 

I was able to work around this problem by removing the offending file from the repository, but this of course is generally not an ideal solution.

(1) 
java.lang.IllegalArgumentException: Revision malformed: branchRevision
    at
org.eclipse.team.internal.ccvs.core.client.listeners.LogListener.getBranchRevision(LogListener.java:262)
    at
org.eclipse.team.internal.ccvs.core.client.listeners.LogListener.messageLine(LogListener.java:199)

Comment 1 David Williams

2011-09-21 13:12:08 EDT

*** Bug 350608 has been marked as a duplicate of this bug. ***

Comment 2 Missing name Mising name

2012-03-19 07:32:15 EDT

(In reply to comment #0)
> Created attachment 198850 [details]
> Problematic file
> 
> After moving up from Helios to Indigo it was soon noticed that previously
> existing CVS branches in WTP could not be displayed for a particular module
> using Eclipse 3.7.  An exception was logged (1).  I entered bug 350608 as a
> result as I was unsure of the cause of this issue.  After doing some debugging
> I found that a particular file (attached) in our repository was causing the
> exception.  This file looked a bit questionable, but it hadn't caused problems
> in the past.  After some more digging, it appears that changes made for bug
> 76386 were the cause of this issue occurring only in 3.7.
> 
> In LogListener, line 199, the new call to this.getBranchRevision(revision)
> appears to assume that the revision will be an actual revision, and not a
> COMMENT of BRANCH_REVISION.  I don't claim to fully understand the workings of
> the containing method, but thought I would point out where the problem appears
> to be. 
> 
> I was able to work around this problem by removing the offending file from the
> repository, but this of course is generally not an ideal solution.
> 
> (1) 
> java.lang.IllegalArgumentException: Revision malformed: branchRevision
>     at
> org.eclipse.team.internal.ccvs.core.client.listeners.LogListener.getBranchRevision(LogListener.java:262)
>     at
> org.eclipse.team.internal.ccvs.core.client.listeners.LogListener.messageLine(LogListener.java:199)

I'm running into the same problem. How did you find the file causing the error?

Comment 3 Neil Hauge

2012-03-20 16:45:48 EDT

(In reply to comment #2)
> (In reply to comment #0)
> 
> I'm running into the same problem. How did you find the file causing the error?

I had to debug the org.eclipse.team.internal.ccvs code, and probably put a breakpoint on IllegalArgumentException.

Comment 4 Lars Vogel

2019-11-14 03:18:02 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.