Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 350689

Summary: [formatter] Problems formatting Lua source code
Product: [Tools] CDT Reporter: Anton Leherbauer <aleherb+eclipse>
Component: cdt-editorAssignee: Anton Leherbauer <aleherb+eclipse>
Status: RESOLVED FIXED QA Contact: Anton Leherbauer <aleherb+eclipse>
Severity: normal    
Priority: P3 CC: cdtdoug, yevshif
Version: 8.0   
Target Milestone: 8.0.1   
Hardware: All   
OS: All   
Whiteboard:

Description Anton Leherbauer CLA 2011-06-29 07:29:46 EDT
I am testing the formatter using the Lua source code (version 5.1.4 from http://www.lua.org/download.html) and it seems this worked better with 7.0.2.
With 7.0.2 I get only one formatting problem in print.c. 
With 8.0, there are about 20 and some of the problems change the syntax causing build issues:

ldebug.c:231:3: warning: implicit declaration of function 'elsesetclvalue'
lopcodes.c:57:14: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'luaP_opmodes'
Comment 1 Anton Leherbauer CLA 2011-08-09 04:43:04 EDT
Fixed in master and 8.0.1.
Comment 2 CDT Genie CLA 2011-08-09 05:23:01 EDT
*** cdt git genie on behalf of Anton Leherbauer ***

    Bug 350689 - [formatter] Problems formatting Lua source code

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=17df657d34c805bbe4d446b5f4abac849d94cdc1
Comment 3 CDT Genie CLA 2011-08-09 05:23:02 EDT
*** cdt git genie on behalf of Anton Leherbauer ***

    Bug 350689 - [formatter] Problems formatting Lua source code

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=24d603a17822c483de68459894cc264aa808a3c8