Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 350663

Summary:

For terminal service, non-login mode, user need not input prompt

Product:

[Tools] TCF

Reporter:

Liping Ke <liping.ke>

Component:

RSE

Assignee:

Anna Dushistova <anna.dushistova>

Status:

RESOLVED FIXED

QA Contact:

Anna Dushistova <anna.dushistova>

Severity:

enhancement

Priority:

CC:

cdtdoug

Version:

unspecified

Target Milestone:

0.4.0

Hardware:

All

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
remove command prompt requirement for terminal/shell service	none
remove command prompt requirement for terminal/shell service	anna.dushistova: iplog+

Description Liping Ke

2011-06-29 03:59:50 EDT

Build Identifier: 

Currently, terminal/shell service is running as non-login mode, users don't need to input command prompt in the Connection Properties at all. We can simply return success in login logic module for non-login mode.

Reproducible: Always

Comment 1 Liping Ke

2011-06-29 04:09:02 EDT

Created attachment 198796 [details]
remove command prompt requirement for terminal/shell service

Hi, Anna

I made the patch for solving the problem.

For non-login mode, we can simply skip login step and return success code.
Also, in the patch, I open the switch for login mode so that user can change the switch. For agent side, if user open the login service, user can also set login service in java side. It's not perfect right now, but better than none. If user needs login for terminal/shell service, he/she still needs to set command prompt. Currently, we have no way for avoiding this.

Thanks a lot for your help!
Any problem, just let me know!
criping

Comment 2 Anna Dushistova

2011-07-02 12:11:27 EDT

Patch seems okay.
Could you please edit the copyright in the file to reflect the change you made?
And also could you please post a legal disclaimer here that you developed the code from scratch and are authorized by your employer to make this contribution under EPL?

Thanks!

Comment 3 Liping Ke

2011-07-04 02:43:09 EDT

Hi, anna

This small patch is for removing command prompt detect for non-login mode.
This patch is developed by Liping Ke from scratch and is authorized by My employer Intel Corp.
I also updated copyright section. The new patch is in the attachment.

Thanks a lot for your help!
criping

Comment 4 Liping Ke

2011-07-04 02:44:07 EDT

Created attachment 199026 [details]
remove command prompt requirement for terminal/shell service

update the copyright section.

Comment 5 Anna Dushistova

2011-07-07 08:57:29 EDT

Patch applied to trunk, thanks!