Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 350593

Summary:

ChangeLog does not consider a dirty ChangeLog editor as a change to the ChangeLog file and adds new ChangeLog entries to the editor

Product:

[Tools] Linux Tools

Reporter:

Ken Leung <plcnkl>

Component:

ChangeLog

Assignee:

Jeff Johnston <jjohnstn>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

linux.changelog-inbox, overholt, plcnkl

Version:

unspecified

Target Milestone:

0.8.1

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
Adds dirty detection detection and pass it to GNUFormat	jjohnstn: iplog+
Added a field, getter and setter so the boolean flag can be passed to GNUFormat to force it to merge a ChangeLog instead of creating new entries.	jjohnstn: iplog+
Added dirty editor detection support by checking the boolean flag included by ChangeLogEditor.	jjohnstn: iplog+

Description Ken Leung

2011-06-28 10:57:49 EDT

Build Identifier: 

The current implementation only compares the ChangeLog file in the local repository with the master.  So if the user prepared a ChangeLog earlier in the day without saving the ChangeLog (the editor opening the ChangeLog is dirty), tries to make additional changes to files and prepare another ChangeLog, ChangeLog will create a new ChangeLog entry instead of merging/appending changes to the entry created by the last prepare.

Reproducible: Always

Steps to Reproduce:
1.Make changes to files.
2.Prepare ChangeLog.
3.On the same day, make additional changes to files.
4.On the same day, prepare ChangeLog again.

Comment 1 Ken Leung

2011-06-28 10:59:48 EDT

Created attachment 198744 [details]
Adds dirty detection detection and pass it to GNUFormat

Comment 2 Ken Leung

2011-06-28 11:00:53 EDT

Created attachment 198745 [details]
Added a field, getter and setter so the boolean flag can be passed to GNUFormat to force it to merge a ChangeLog instead of creating new entries.

Comment 3 Ken Leung

2011-06-28 11:01:59 EDT

Created attachment 198746 [details]
Added dirty editor detection support by checking the boolean flag included by ChangeLogEditor.

Comment 4 Jeff Johnston

2011-07-14 16:49:08 EDT

Patches committed to HEAD.

Comment 5 Andrew Overholt

2011-08-15 14:34:30 EDT

Please cherry-pick fixes targetted at 0.8.1 to the stable-0.8 branch.  Thanks.