Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 350420

Summary: CommitIntegrityCheck should check old set target only if it's containtment or has eOpp
Product: [Modeling] EMF Reporter: Caspar D. <caspar_d>
Component: cdo.coreAssignee: Caspar D. <caspar_d>
Status: CLOSED FIXED QA Contact: Eike Stepper <stepper>
Severity: normal    
Priority: P3 CC: saulius.tvarijonas
Version: 4.1Flags: stepper: review+
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch v1 none

Description Caspar D. CLA 2011-06-27 06:09:57 EDT
Currently, for a CDOSetFeatureDelta, the CommitIntegrity checks always
demands that the feature's old target be included. This is incorrect.
There is a need to include it only when the reference is containment
or has an eOpposite.
Comment 1 Caspar D. CLA 2011-06-27 06:10:34 EDT
NoMagic internal note: SVR-3267
Comment 2 Caspar D. CLA 2011-06-27 06:14:28 EDT
Created attachment 198633 [details]
Patch v1
Comment 3 Eike Stepper CLA 2011-07-02 06:01:24 EDT
Changing to 4.1 to ensure that the fix will "last". Please clone this bugzilla
to 4.0 if you want a maintenance fix, too.
Comment 4 Eike Stepper CLA 2011-07-02 06:18:57 EDT
Go ahead and commit to *trunk* .
Comment 5 Caspar D. CLA 2011-07-04 01:02:42 EDT
Committed revision 8578.
Comment 6 Caspar D. CLA 2011-07-04 01:44:32 EDT
Cloned for 4.0 as bug 351044
Comment 7 Eike Stepper CLA 2012-09-21 07:17:55 EDT
Closing.