Bug 350397

Description Martin Thomson 2011-06-27 01:41:59 EDT

The method SelectChannelConnector.close() does not work properly.  According to the documentation [1], as well as the behaviour of the SocketConnector class, this method should only close the server socket without affecting any existing connections that have already been established.

The the close() method does too much work.  It stops the SelectorManager, which in turn stops all the SelectSets.  To fix the problem, the stopping of the SelectorManager should be moved to the SelectChannelConnector.doStop() method just before calling super.doStop().

The methods can be changed to:

    public synchronized void close() throws IOException
    {
        if (_acceptChannel != null)
            _acceptChannel.close();
        _acceptChannel = null;
        _localPort = -2;
    }

    @Override
    protected synchronized void doStop() throws Exception
    {
        if (_manager.isRunning())
        {
            try
            {
                _manager.stop();
            }
            catch (Exception e)
            {
                Log.warn(e);
            }
        }
        super.doStop();
    }


[1] http://docs.codehaus.org/display/JETTY/How+to+gracefully+shutdown