Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 350395

Summary:

NPE in SystemView.updatePropertySheet()

Product:

[Tools] Target Management

Reporter:

Masao Nishimoto <e03616>

Component:

RSE

Assignee:

David McKnight <dmcknigh>

Status:

RESOLVED FIXED

QA Contact:

Martin Oberhuber <mober.at+eclipse>

Severity:

normal

Priority:

CC:

dmcknigh, xuanchen

Version:

3.0.3

Flags:

xuanchen: review+

Target Milestone:

3.0.3+

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
patch to check for null	none

Description Masao Nishimoto

2011-06-27 01:20:19 EDT

This is R3_0 maintenance stream.  The stack trace is as follows.  At the time of the NPE, "selection" is empty, and "first" is null.

Caused by: java.lang.NullPointerException
	at org.eclipse.rse.internal.ui.view.SystemView.updatePropertySheet(SystemView.java:5896)
	at org.eclipse.rse.internal.ui.view.SystemView.updatePropertySheet(SystemView.java:5875)
	at org.eclipse.rse.internal.ui.view.SystemView$7.run(SystemView.java:1421)

Comment 1 David McKnight

2011-06-27 16:18:05 EDT

Created attachment 198684 [details]
patch to check for null

Comment 2 David McKnight

2011-06-27 16:18:49 EDT

Masao, does the attached patch fix the problem?

Comment 3 Masao Nishimoto

2011-06-28 23:28:09 EDT

The patch fixed the problem.

Comment 4 David McKnight

2011-06-29 08:48:15 EDT

Xuan, could you please review this patch?

Comment 5 Xuan Chen

2011-06-29 11:34:43 EDT

The fix looks good.  Thanks.

Comment 6 David McKnight

2011-06-29 11:40:20 EDT

Thanks for the review, Xuan. I've committed the changes to the R3_0_maintenance stream.