Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 350315

Summary: [dstore] regress change made for bug 305218
Product: [Tools] Target Management Reporter: David McKnight <dmcknigh>
Component: RSEAssignee: David McKnight <dmcknigh>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: normal    
Priority: P3 CC: xuanchen
Version: 3.2Flags: xuanchen: review+
Target Milestone: 3.3.1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 350316    
Attachments:
Description Flags
patch to always transfer via UTF-8 none

Description David McKnight CLA 2011-06-24 14:18:38 EDT 
It looks like bug 305218 was actually an invalid bug and that, in reality, the environment in which it was produced was not suitable for the DBCS language involved.  The fix that went in appeared to work in this invalid environment. Recently, in the correct environment, it was discovered that RSE shells weren't working correctly for DBCS character display.  It turns out that this is the result of the fix for bug 305218.
Comment 1 David McKnight CLA 2011-06-24 14:25:38 EDT 
Created attachment 198565 [details]
patch to always transfer via UTF-8
Comment 2 David McKnight CLA 2011-06-24 15:49:20 EDT 
Xuan, could you please review this patch?
Comment 3 Xuan Chen CLA 2011-06-24 16:25:53 EDT 
The fix looks good.  Thanks.
Comment 4 David McKnight CLA 2011-06-27 08:17:45 EDT 
Thanks for the review, Xuan.  I've committed the change to cvs.