Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 350304

Summary: [pdebuild] Clean up unnecessary logging
Product: z_Archived Reporter: Andrew Overholt <overholt>
Component: LinuxToolsAssignee: Packaging Tools Inbox <linux.packagingtools-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: akurtakov, krzysztof.daniel
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Patch proposition akurtakov: iplog+

Description Andrew Overholt CLA 2011-06-24 13:14:48 EDT 
In pdebuild.sh, we do a lot of ls *blah*.  It would be nice to pipe the output of this to /dev/null and react to non-zero return codes.  ls *blah* 2> /dev/null, etc.
Comment 1 Krzysztof Daniel CLA 2011-09-11 03:24:11 EDT 
Created attachment 203120 [details]
Patch proposition

should the execution of the script also be stopped when ls -d return an error?

The error seems to just say that nothing matches "optional" in particular location - but since it is based on wildcards, you do not really know if it is an error or maybe it works as designed.

I thought about checking if there is at least one match in all locations, but I am not sure if this is a right thing to do.
Comment 2 Alexander Kurtakov CLA 2011-09-13 14:40:50 EDT 
(In reply to comment #1)
> Created attachment 203120 [details]
> Patch proposition
> 
> should the execution of the script also be stopped when ls -d return an error?
> 
> The error seems to just say that nothing matches "optional" in particular
> location - but since it is based on wildcards, you do not really know if it is
> an error or maybe it works as designed.
> 
> I thought about checking if there is at least one match in all locations, but I
> am not sure if this is a right thing to do.

Thanks for looking into this Christopher, ideally one would test it on Fedora with a few plugins to verify that no corner case is broken. I'll try to test it this week too and either apply or report a problem.
Comment 3 Alexander Kurtakov CLA 2011-09-29 07:37:53 EDT 
Applied in master 1eb6f9e..ae6a179.

Thanks again.