Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 350234

Summary:	[Preferences] FieldEditor*.applyFont() never called
Product:	[Eclipse Project] Platform	Reporter:	Daniel Krügler <daniel.kruegler>
Component:	UI	Assignee:	Platform UI Triaged <platform-ui-triaged>
Status:	REOPENED ---	QA Contact:
Severity:	minor
Priority:	P3	CC:	karsten.thoms, prakash
Version:	3.6.1
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
See Also:	https://git.eclipse.org/r/111843 https://git.eclipse.org/r/112019
Whiteboard:

Description Daniel Krügler

2011-06-24 07:14:06 EDT

Build Identifier: M20100909-0800

FieldEditorPreferencePage#applyFont() itself is never called nor does any other class of the preferences sub-library invoke FieldEditor#applyFont() - neither FieldEditorPreferencePage itself nor any other class!

This looks like a defect to me. Either FieldEditorPreferencePage.applyFont() should be called as part of the FieldEditorPreferencePage implementation or the applyFont() should be marked as deprecated. 

Reproducible: Always

Comment 1 Eclipse Genie

2017-11-18 10:02:15 EST

New Gerrit change created: https://git.eclipse.org/r/111843

Comment 2 Daniel Krügler

2017-11-18 10:04:15 EST

(In reply to Eclipse Genie from comment #1)
> New Gerrit change created: https://git.eclipse.org/r/111843

This patch proposal ensures that applyFont() is now called within createContents(). I would appreciate a review of that patch.

Comment 3 Eclipse Genie

2017-11-21 16:04:40 EST

New Gerrit change created: https://git.eclipse.org/r/112019

Comment 4 Eclipse Genie

2019-11-27 18:30:17 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.

Comment 5 Daniel Krügler

2019-11-28 01:07:15 EST

(In reply to Eclipse Genie from comment #4)
> This bug hasn't had any activity in quite some time. Maybe the problem got
> resolved, was a duplicate of something else, or became less pressing for
> some reason - or maybe it's still relevant but just hasn't been looked at
> yet.
> 
> If you have further information on the current state of the bug, please add
> it. The information can be, for example, that the problem still occurs, that
> you still want the feature, that more information is needed, or that the bug
> is (for whatever reason) no longer relevant.
> 
> --
> The automated Eclipse Genie.

Please don't close this issue. The problem still exists and I have provided a patch proposal two years(!) ago. Please review the patch.

Comment 6 Karsten Thoms

2020-09-30 18:46:27 EDT

As requested this should not be closed. With the patch I did not see a negative effect in the workbench's preference pages that inherit from FieldEditorPreferencePage. Actually there was no change visible. Could you elaborate under which conditions you consider this as a bug? Do you have an example of a preference page that gets fixed with the change? Could you attach before/after screenshot or an example?