Bugzilla – Full Text Bug Listing
| Summary: | Add back unique disabled icon support for ToolItems | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Markus Keller <markus.kell.r> | ||||
| Component: | UI | Assignee: | Dean Roberts <dean.t.roberts> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | daniel_megert, dean.t.roberts, deepakazad, emoffatt, markus.kell.r, neil.hauge, prakash, pwebster, remy.suen | ||||
| Version: | 4.2 | ||||||
| Target Milestone: | 4.2 M6 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 334303 | ||||||
| Attachments: |
|
||||||
I guess the bug is with e4. Moving... Version: 4.1.0 Build id: I20110620-1631 Still in I20111110-2200. This would seem important to fix for Juno. Wonder if we need to introduce a disabledIconURI feature to MUILabel or MItem? If enablement is not an attribute in the model we could use a tag... Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=3e63299b07847e6a4a02c58cca80a993f1905da8 For now just storing the iconURI as transient data on the model object. Going forward, I believe we need to give some thought on how to represent the various flavours of icons in the model. I will open a separate defect for this discussion. Verified in 4.2-I20120312-1730. |
Created attachment 198517 [details] Screenshots Bad rendering of disabled icons in main toolbar. Screenshot shows 3.7 in the back and 4.1 in front.