Bugzilla – Full Text Bug Listing
| Summary: | Bad initial workbench window location | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Markus Keller <markus.kell.r> | ||||
| Component: | UI | Assignee: | Platform UI Triaged <platform-ui-triaged> | ||||
| Status: | VERIFIED FIXED | QA Contact: | Eric Moffatt <emoffatt> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | bsd, daniel_megert, emoffatt, prakash | ||||
| Version: | 4.2 | ||||||
| Target Milestone: | 4.2 M3 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Markus Keller
Version: 4.1.0 Build id: I20110620-1631 Still broken in M20110817-2001. Created attachment 203006 [details]
Patch to change default values for Window.{x,y,width,height}
Since we don't expose EMF's eIsSet() through our interfaces, the following patch (1) adjusts the Window defaults for x, y, widght, and height to −1, to indicate "unknown", and (2) changes WBWRenderer to only override the window's bounds settings where set.
Thanks Brian, with this patch how do the various platforms behave ? My main concern is with the width / height which were explicitly defaulted in 3.x. +1 that we certainly shouldn't be hard-coding the position... (In reply to comment #4) > Thanks Brian, with this patch how do the various platforms behave ? My main > concern is with the width / height which were explicitly defaulted in 3.x. > > +1 that we certainly shouldn't be hard-coding the position... What width & height defaults were we using in 3.x? Prior to this patch, we were defaulting height / width values to 0, and as a result were simply passing 0 on to Shell#setBounds(). With this patch, we maintain the current height / width if not set. So we should be in no worse a situation than we were previously. And of course in my testing, my monitors were setup such that the X and Y were > 0, even when multiheaded. But now I have the monitors switched around, the X and Y can be < 0, causing the windows to be relocated to the principal monitor (bug 358627). Fix committed: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=df1b95a345efa309021f9f8d0b8137848a0856ae Verified for M4 |