Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 350121

Summary:

Fix warnings from the build page (for WTP 3.2.5)

Product:

[WebTools] WTP Common Tools

Reporter:

Gary Karasiuk <karasiuk>

Component:

wst.validation

Assignee:

Gary Karasiuk <karasiuk>

Status:

CLOSED FIXED

QA Contact:

Chuck Bridgham <cbridgha>

Severity:

normal

Priority:

Version:

3.2.4

Target Milestone:

3.2.5

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
patch to remove the various compiler warnings	none
same patch but with fixed up copyrights	none
fix the last warning	none

Description Gary Karasiuk

2011-06-23 04:44:30 EDT

Compiler Report

Compiler: Eclipse Compiler for Java(TM) Version: 0.A76_R36x, 3.6.2

Number of source files: 138 Number of classfiles: 215

Problems: 6 (Errors: 0 Warnings: 6 )

Source File: org/eclipse/wst/validation/internal/ValidatorMetaData.java
    1. WARNING: DeadCode

    Dead code

    ValidatorMetaData.java :

    349 : for (int j=0;j<sourceContainers.length; j++) {
Source File: org/eclipse/wst/validation/internal/ValidatorTypeFilter.java
    1. WARNING: DeadCode

    Dead code

    ValidatorTypeFilter.java :

    81 : for (int i = 0; i < clInterfaces.length; i++) {
Source File: org/eclipse/wst/validation/internal/ValManager.java
    1. WARNING: UnusedPrivateMethod

    The method reset() from the type ValManager.ValidatorIdManager is never used locally

    ValManager.java :

    1072 : public synchronized void reset(){
    2. WARNING: UnusedPrivateMethod

    The method getIds(BitSet) from the type ValManager.ValidatorIdManager is never used locally

    ValManager.java :

    1082 : public synchronized String[] getIds(BitSet bs){
Source File: org/eclipse/wst/validation/internal/ValPrefManagerGlobal.java
    1. WARNING: UnusedPrivateMethod

    The method getVersion() from the type ValPrefManagerGlobal.Global is never used locally

    ValPrefManagerGlobal.java :

    624 : public int getVersion() {
Source File: org/eclipse/wst/validation/internal/model/FilterRule.java
    1. WARNING: DeadCode

    Dead code

    FilterRule.java :

    515 : if (name == null)return Boolean.FALSE;

Comment 1 Gary Karasiuk

2011-06-23 05:24:55 EDT

Created attachment 198456 [details]
patch to remove the various compiler warnings

Comment 2 Gary Karasiuk

2011-06-23 05:27:34 EDT

Created attachment 198457 [details]
same patch but with fixed up copyrights

Comment 3 Gary Karasiuk

2011-06-24 14:53:18 EDT

Released to 3.2.5 and HEAD.

Comment 4 Gary Karasiuk

2011-06-24 14:54:01 EDT

resolving

Comment 5 Gary Karasiuk

2011-06-26 15:19:48 EDT

Created attachment 198616 [details]
fix the last warning

Comment 6 Gary Karasiuk

2011-06-26 15:30:05 EDT

Applied second patch to 3.2.5 and HEAD.

Comment 7 Gary Karasiuk

2011-06-27 06:22:37 EDT

I've confirmed that all the build warnings have now been fixed.