Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 350110

Summary:	remove REMOTE_SSH_COMMAND from build scripts
Product:	[WebTools] WTP Releng	Reporter:	David Williams <david_williams>
Component:	releng	Assignee:	David Williams <david_williams>
Status:	RESOLVED FIXED	QA Contact:	David Williams <david_williams>
Severity:	normal
Priority:	P3	CC:	ccc
Version:	3.10
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:

Description David Williams

2011-06-22 22:08:13 EDT

In looking to make the builds easier to use by others, one of the current "hard coded" issues is using the REMOTE_SSH_COMMAND to do our signing. This was the recommendation ... like 5 years ago! ... but, now, its accepted that "builderIDs" need the ability to sign, such as hudsonBuild, or, our own wtpBuild. 

Webmasters will be setting up/confirming this soon ... Thursday? ... at which time we should remove all references to REMOTE_SSH_COMMAND.

Comment 1 David Williams

2011-06-22 22:54:40 EDT

Hmm, looking at this now, we do not use for signing, exactly, that's a different problem, tracked in bug 350114. 

REMOTE_SSH_COMMAND is used in a few scripts such as to copy things to "downloads" when using or logged in under the builder id (wtpBuild). 

But, from what I can see, we do not use it in any automatic scripts, and can just remove it. 

When doing the "promotes" or copies, we should use committer IDs anyway, instead of wtpBuild. 

Besides just removing REMOTE_SSH_COMMAND and related code, a "nice to have" might be for those scripts to simply check for something like 

if [ $USER == "wtpBuild" ] then ; 
echo "nice message that this script can not be used from wtpBuild"
fi 

Since otherwise, the failure that will occur, can be quite vague and hard to pin down. But ... usually not a problem, since we do not use these script from any automatic builds. (I think maybe at some point in past we did?)

Comment 2 David Williams

2011-07-02 20:45:34 EDT

removed