Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 350087

Summary: [1.7] JavaElementLabelComposer has problems rendering references to @PolymorphicSignature methods
Product: [Eclipse Project] JDT Reporter: Markus Keller <markus.kell.r>
Component: UIAssignee: Markus Keller <markus.kell.r>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, markus.kell.r, Michael_Rennie
Version: 3.7   
Target Milestone: 3.7.1   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 350496    
Bug Blocks:    
Attachments:
Description Flags
Fix none

Description Markus Keller CLA 2011-06-22 14:17:54 EDT 
BETA_JAVA7, follow-up to bug 349486 comment 8

JavaElementLabelComposer has problems rendering references to @PolymorphicSignature methods.

I'm not yet completely sure where the problem is, but I currently think it's on the UI side.

Observations:
- Even with the patch, the IMethod for the reference has the varargs flag set.
- The workaround for bug 99137 in JavaElementLabelComposer.java:401 sets the variable 'types' to a wrong value, so we lose some parameters.

I don't think the varargs flag can be removed from the IMethod. I guess we also need to add knowledge about the @PolymorphicSignature methods in the JavaElementLabelComposer, since these are otherwise hard to distinguish from other methods whose resolved signature is not the same as the IMethod#getSignature().
Comment 1 Markus Keller CLA 2011-06-22 14:18:52 EDT 
I'll look at this tomorrow.
Comment 2 Markus Keller CLA 2011-07-01 08:50:02 EDT 
Created attachment 198964 [details]
Fix
Comment 3 Markus Keller CLA 2011-07-05 08:35:08 EDT 
Fix has been released. Forgot to close this bug.
Comment 4 Michael Rennie CLA 2011-07-20 16:05:56 EDT 
verified. 

The labels look fine but I could not find an occurrence of labels like 'invokeExact(Object... arg0)' or 'invokeExact(arg0)' like are tested for in the patch.