Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 350079

Summary:

EGit should be by included in Java package

Product:

[Technology] EPP

Reporter:

Alexis Hassler <eclipse>

Component:

java-package

Assignee:

Steffen Pingel <steffen.pingel>

Status:

RESOLVED FIXED

QA Contact:

Severity:

minor

Priority:

CC:

b.muskalla, caniszczyk, ian.skerrett, jens.baumgart, matthias.sohn, mknauer, pwebster, remy.suen, stefan.lay, steffen.pingel, wayne.beaton

Version:

unspecified

Target Milestone:

1.4.0 RC2

Hardware:

All

OS:

All

See Also:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=387136

Whiteboard:

Bug Depends on:

Bug Blocks:

350232

Attachments:

Description	Flags
patch for EPP Java package	none
updated patch for Indigo	none
patch for Juno	none

Description Alexis Hassler

2011-06-22 13:01:39 EDT

Build Identifier: 20110615-0604

eGit is included in several package. That is great. But it is not in the java package.

As git is becoming more and more important in the java community, eGit should be included in the java package. This way it could be a real concurrent for Netbeans and Intellij

Reproducible: Always

Comment 1 Steffen Pingel

2011-06-23 12:40:22 EDT

I agree that EGit would be a great addition to the package. I'll put this on the list for the next release.

Comment 2 Ian Skerrett

2011-06-23 12:56:10 EDT

(In reply to comment #1)
> I agree that EGit would be a great addition to the package. I'll put this on
> the list for the next release.

I am hoping by next release you mean SR1.   We should also add it to the Java EE package.

Comment 3 Markus Knauer

2011-08-03 01:51:26 EDT

*** Bug 353613 has been marked as a duplicate of this bug. ***

Comment 4 Steffen Pingel

2011-08-08 07:15:52 EDT

I'm open to making this happen for SR1 since there has been quite a bit of interest in EGit and this would be a great benefit for the Java package. 

To minimize the risk, it'd be great if someone (from the EGit team) could answer the usual questions:

* What is the impact on the download size of the Java package if EGit is included?
* Does EGit depend on components (e.g. PDE) that are not already part of the Java package?
* Does EGit require additional components that would not be shipped as part of the Java package (e.g. an external git client)?
* Does EGit log any output to the console?
* Does EGit have a startup extension?
* Does EGit contribute any (modal) dialogs that are visible on startup?
* What is the runtime impact of EGit if it's not used (i.e. no project is connected to EGit, all EGit views are closed)?
* How many UI contributions does EGit add to the Java perspective?

Comment 5 Jens Baumgart

2011-08-26 08:51:48 EDT

Answers for the questions above:

* What is the impact on the download size of the Java package if EGit is
included?

8,7 MB

* Does EGit depend on components (e.g. PDE) that are not already part of the
Java package?

No

* Does EGit require additional components that would not be shipped as part of
the Java package (e.g. an external git client)?

No

* Does EGit log any output to the console?

No (I found one System.out in class GitIndex. We will remove this / drop GitIndex)

* Does EGit have a startup extension?

No

* Does EGit contribute any (modal) dialogs that are visible on startup?

No

* What is the runtime impact of EGit if it's not used (i.e. no project is
connected to EGit, all EGit views are closed)?

Small runtime impact. Git Decorator is called for resources but exits soon.

* How many UI contributions does EGit add to the Java perspective?

Zero

Comment 6 Remy Suen

2011-08-26 20:16:56 EDT

(In reply to comment #5)
> * How many UI contributions does EGit add to the Java perspective?
> 
> Zero

Correction, we add a 'Open Git Commit...'  tool item to the left of 'Open Type' in the workbench window's tool bar. It also shows up in the 'Navigate' menu (though that is not as "intrusive" as showing things in the tool bar).

Comment 7 Steffen Pingel

2011-08-27 19:37:24 EDT

Thanks Jens. That all sounds reasonable to me. Markus do you know of any reason that would stop us from including EGit for Indigo SR1 RC2? In case there are unexpected problems we could still revert for RC3.

Comment 8 Steffen Pingel

2011-08-29 18:09:34 EDT

Created attachment 202365 [details]
patch for EPP Java package

Comment 9 Steffen Pingel

2011-08-31 10:46:17 EDT

Created attachment 202530 [details]
updated patch for Indigo

Comment 10 Steffen Pingel

2011-08-31 10:52:48 EDT

Created attachment 202532 [details]
patch for Juno

Comment 11 Steffen Pingel

2011-08-31 10:53:54 EDT

I have committed the patches to the INDIGO branch and HEAD which should add EGit to the next packaging build for Indigo SR1 RC2 and Juno M2. Markus, please let me know in case anything else needs to be updated.

Comment 12 Remy Suen

2011-09-02 06:34:51 EDT

(In reply to comment #6)
> Correction, we add a 'Open Git Commit...'  tool item to the left of 'Open Type'
> in the workbench window's tool bar.

With regards to this tool item, Dani has opened a bug requesting that it be removed, see bug 356554.